Add "clean name" function for ROMs to improve ConsoleGrid results and Steam shortcut names #251
Conversation
…for banner lookups and shortcut names.
Move hidden file check to is_valid_rom(). Rework directory crawl in find_roms() for efficiency. Remove os.makedirs(self.rom_directory()) - little point in doing that.
Add stub for loop to detect ROMs with duplicate names (issue #248).
|
Awesome! Will do a thorough review soon, but just had a quick question. So this change means that Ice will take a filename like "Mega Max X [USA].sfc" and correctly understand that "Mega Man X" is the name? If so, then this is definitely something that needed to be done. There doesn't seem to be a consistent naming scheme online though, so are there certain patterns that you are trying to clean? What are those patterns? Also, would you please squash together all of the "Fix linter errors and comment out" commits? And what is the lint command you are running? |
| from persistence.config_file_backing_store import ConfigFileBackingStore | ||
| from emulator import Emulator | ||
| # from persistence.config_file_backing_store import ConfigFileBackingStore | ||
| # from emulator import Emulator |
There was a problem hiding this comment.
Please don't leave commented imports. If they are unused then you can just delete them.
|
Also, I'm only partway through, but have you rebased to the most recent version of Ice? It looks like a lot of the logic you are changing doesn't exist anymore. |
There we go. This took a while longer than I had planned with life getting in the way, but I've finally had the time to tidy this up and give it a good testing.