changed ROM-directory configuration so now no new "ROM"-directory is created #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 7, 2013 19:02
…eated. Instead the definied directory in the config-file is actually used.
…eated. Instead the definied directory in the config-file is actually used.
…eated. Instead the definied directory in the config-file is actually used.
scottrice
added a commit
that referenced
this pull request
Oct 7, 2013
changed ROM-directory configuration so now no new "ROM"-directory is created
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the final pull request. Sorry for closing the other one, that wasn't my intention.
I think the way the "ROMs" directory configuration is handled is not perfect. In my eyes there's no need to always create a directory called roms where the rom-files should be stored. Instead the user should be allowed to define an own directory. The following patch should accomplish that.