Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete ceno_rt/Cargo.lock #803

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Remove obsolete ceno_rt/Cargo.lock #803

merged 1 commit into from
Jan 3, 2025

Conversation

matthiasgoergens
Copy link
Collaborator

@matthiasgoergens matthiasgoergens commented Jan 3, 2025 •
edited
Loading

830b840 / PR#759 made ceno_rt/Cargo.lock obsolete, but we forgot deleting it back then.

Extracted from #802

@matthiasgoergens
Remove obsolote ceno_rt/Cargo.lock
7790ca8 
830b840 / PR#759 made `ceno_rt/Cargo.lock`
obsolete, but we forgot deleting it back then.
hero78119
hero78119 reviewed Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we also add ceno_rt/Cargo.lock into .gitignore explicitly

@matthiasgoergens matthiasgoergens mentioned this pull request Jan 3, 2025
Merged
@matthiasgoergens
Copy link
Collaborator Author

matthiasgoergens commented Jan 3, 2025 •
edited
Loading

how about we also add ceno_rt/Cargo.lock into .gitignore explicitly

No need, it will never be (re-) created, because ceno_rt is now part of the overall workspace. So it's lock is now folded into the the root's Cargo.lock.

If it gets created for some reasons, I'd rather figure out why, instead of suppressing it.

@matthiasgoergens matthiasgoergens changed the title Remove obsolote ceno_rt/Cargo.lock Remove obsolete ceno_rt/Cargo.lock Jan 3, 2025
@hero78119 hero78119 added this pull request to the merge queue Jan 3, 2025
Merged via the queue into master with commit 0f11835 Jan 3, 2025
4 checks passed
@hero78119 hero78119 deleted the matthias/remove-cenort-cargo-lock branch January 3, 2025 08:49
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
@matthiasgoergens
Deduplicate magic syscall number (#802)
a3348f1 
Also make examples visible to a plain `cargo clippy --workspace
--all-targets`. But that's now extracted into
#804 to be merged first. Similar
with #803

We are using a technique inspired by the SP1 example already mentioned
in `ceno_emul/src/syscalls.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hero78119 hero78119 hero78119 approved these changes

@lispc lispc Awaiting requested review from lispc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasgoergens @hero78119