Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI hints #829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcalancea
Copy link
Collaborator

@mcalancea mcalancea commented Feb 11, 2025

Makes a couple of changes to improve the experience of passing hints to guest programs via the CLI.

  • Eliminates debug_memory_ranges from src/e2e.rs because it fails when hints are non-empty.
  • Introduces a --structured-hints option for bin/e2e.rs. This parses a sequence of u32s in decimal notation from a file and serializes them so that they can be consumed by the guest; i.e, a file containing the values N a1 a2 .. aN will produce hints such that let input: &ArchivedVec<u32> = ceno_rt::read(); in the guest will result in input = [a1, a2.. aN]. This is easier to use than the existing --hints option (now renamed to --raw--hints) which requires the user to serialize the input correctly on their own;

I think in the long-term more general solutions are required to increase compatibility of guest programs with bin/e2e.rs, but this PR is an ok compromise for my day-to-day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant