Disable default helm modeline functions for helm-ag and helm-fd #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +228,8 @@ If DEFAULT is non-nil, set the default mode-line for all buffers." | |||
|
|
|||
| ;; Special handles | |||
| (advice-add #'helm-display-mode-line :after #'doom-modeline-set-helm-modeline) | |||
| (setq helm-ag-show-status-function #'doom-modeline-set-helm-modeline)) | |||
| (setq helm-ag-show-status-function nil | |||
| helm-fd-mode-line-function nil)) | |||
There was a problem hiding this comment.
Actually there is nothing more to do here. For helm-ag and helm-fd this is the best solution as setting those functions to nil prevents the modeline from being overwritten (in the code they check whether this is nil).
There was a problem hiding this comment.
I mean when disabling doom-modeline-mode, all vars should be restore to the original values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More generic fix for #584