Bug 1017463 - Remove SetLight / GetLight from PHal.ipdl. r=dhylands

sean93park · Jun 11, 2014 · 7fde215 · 7fde215
1 parent b3b134d
commit 7fde215
Show file tree

Hide file tree

Showing 8 changed files with 153 additions and 253 deletions.
diff --git a/hal/Hal.cpp b/hal/Hal.cpp
@@ -420,18 +420,6 @@ void SetScreenBrightness(double aBrightness)
   PROXY_IF_SANDBOXED(SetScreenBrightness(clamped(aBrightness, 0.0, 1.0)));
 }
 
-bool SetLight(LightType light, const LightConfiguration& aConfig)
-{
-  AssertMainThread();
-  RETURN_PROXY_IF_SANDBOXED(SetLight(light, aConfig), false);
-}
-
-bool GetLight(LightType light, LightConfiguration* aConfig)
-{
-  AssertMainThread();
-  RETURN_PROXY_IF_SANDBOXED(GetLight(light, aConfig), false);
-}
-
 class SystemClockChangeObserversManager : public ObserversManager<int64_t>
 {
 protected:

diff --git a/hal/Hal.h b/hal/Hal.h
@@ -168,24 +168,6 @@ bool GetCpuSleepAllowed();
  */
 void SetCpuSleepAllowed(bool aAllowed);
 
-/**
- * Set the value of a light to a particular color, with a specific flash pattern.
- * light specifices which light.  See Hal.idl for the list of constants
- * mode specifies user set or based on ambient light sensor
- * flash specifies whether or how to flash the light
- * flashOnMS and flashOffMS specify the pattern for XXX flash mode
- * color specifies the color.  If the light doesn't support color, the given color is
- * transformed into a brightness, or just an on/off if that is all the light is capable of.
- * returns true if successful and false if failed.
- */
-bool SetLight(hal::LightType light, const hal::LightConfiguration& aConfig);
-/**
- * GET the value of a light returning a particular color, with a specific flash pattern.
- * returns true if successful and false if failed.
- */
-bool GetLight(hal::LightType light, hal::LightConfiguration* aConfig);
-
-
 /**
  * Register an observer for the sensor of given type.
  *

diff --git a/hal/HalInternal.h b/hal/HalInternal.h
@@ -14,7 +14,7 @@
  *
  * The difference between Hal.h and HalInternal.h is that methods declared in
  * HalInternal.h don't appear in the hal namespace. That also means this file
- * should not be included except by HalInternal.h and HalSandbox.h.
+ * should not be included except by HalImpl.h and HalSandbox.h.
  */
 
 #ifndef MOZ_HAL_NAMESPACE

diff --git a/hal/fallback/FallbackLights.cpp b/hal/fallback/FallbackLights.cpp