Skip to content

Commit

Permalink
Remove uncessary TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
Rye authored and Rye committed Feb 9, 2017
1 parent 24bea94 commit 7ae534f
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions ooxml/XSSF/Streaming/AutoSizeColumnTracker.cs
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ private bool implicitlyTrackColumn(int column)
*/
public bool UntrackColumns(Collection<int> columns)
{
//TODO: CHeck for parity
bool result = false;
foreach (var col in columns)
{
Expand Down Expand Up @@ -291,7 +290,6 @@ public int getBestFitColumnWidth(int column, bool useMergedCells)
"Either explicitly track the column or track all columns.", reason);
}
}
//TODO: does java get remove the item from the set
double width = maxColumnWidths[column].getMaxColumnWidth(useMergedCells);
return (int)(256 * width);
}
Expand All @@ -305,7 +303,6 @@ public int getBestFitColumnWidth(int column, bool useMergedCells)
* @since 3.14beta1
*/

//TODO: fix
public void UpdateColumnWidths(IRow row)
{
// track new columns
Expand Down Expand Up @@ -350,7 +347,6 @@ public void UpdateColumnWidths(IRow row)

if (maxColumnWidths.ContainsKey(column))
{
//TODO: pretty sure get doesn't remove entry
ColumnWidthPair pair = maxColumnWidths[column];
UpdateColumnWidth(cell, pair);
}
Expand Down
1 change: 0 additions & 1 deletion ooxml/XSSF/Streaming/SXSSFEvaluationSheet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public SXSSFSheet getSXSSFSheet()

public SXSSFEvaluationCell getCell(int rowIndex, int columnIndex)
{
//TODO: maybe why we want a sorted dict.
SXSSFRow row = _xs._rows[rowIndex];
if (row == null)
{
Expand Down
2 changes: 0 additions & 2 deletions ooxml/XSSF/Streaming/SXSSFFormulaEvaluator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ namespace NPOI.XSSF.Streaming
{
public class SXSSFFormulaEvaluator : XSSFFormulaEvaluator
{
//TODO: Readonly?
private static POILogger logger = POILogFactory.GetLogger(typeof(SXSSFFormulaEvaluator));

private IWorkbook wb;
Expand All @@ -44,7 +43,6 @@ public SXSSFFormulaEvaluator(SXSSFWorkbook workbook) : this(workbook, null, null

}

//TODO: implemented new constructor
private SXSSFFormulaEvaluator(SXSSFWorkbook workbook, WorkbookEvaluator bookEvaluator) : base(bookEvaluator)
{
this.wb = workbook;
Expand Down
4 changes: 0 additions & 4 deletions ooxml/XSSF/Streaming/SXSSFRow.cs
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public bool HasCustomHeight()
return Height != -1;
}

//TODO; Do we lose methods here? SSXSSFCELL -> ICell
public List<ICell> Cells
{
get { return _cells.Values.Select(cell => (ICell) cell).ToList(); }
Expand Down Expand Up @@ -222,7 +221,6 @@ public ICell GetCell(int cellnum)
return GetCell(cellnum, policy);
}

//TODO: Test
public ICell GetCell(int cellnum, MissingCellPolicy policy)
{
CheckBounds(cellnum);
Expand Down Expand Up @@ -325,7 +323,6 @@ public IEnumerator<ICell> GetEnumerator()

public bool MoveNext()
{
//TODO: in my case, i can assume no skipped cells
pos += 1;
return _cells.ContainsKey(pos);
}
Expand All @@ -343,7 +340,6 @@ public class CellIterator : IEnumerator<ICell>
private int pos;
public CellIterator(int lastCellNum, Dictionary<int, SXSSFCell> cells)
{
//TODO: Should be static so I don't know if i can just pass this to here
maxColumn = lastCellNum; //last column PLUS ONE, SHOULD BE DERIVED from cells enum.
pos = 0;
_cells = cells;
Expand Down
1 change: 0 additions & 1 deletion ooxml/XSSF/Streaming/SXSSFSheet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,6 @@ public void RemoveMergedRegion(int index)
_sh.RemoveMergedRegion(index);
}

//TODO:FixME!
public void RemoveRow(IRow row)
{
throw new NotImplementedException();
Expand Down

0 comments on commit 7ae534f

Please sign in to comment.