Single render for multiple file removal from working set (microsoft#2…

…34684)

only render once when removing many files from working set

src/vs/workbench/contrib/chat/browser/chatAttachmentModel.ts

@@ -33,8 +33,10 @@ export class ChatAttachmentModel extends Disposable {
 		this._onDidChangeContext.fire();
 	}
 
-	delete(variableEntryId: string) {
-		this._attachments.delete(variableEntryId);
+	delete(...variableEntryIds: string[]) {
+		for (const variableEntryId of variableEntryIds) {
+			this._attachments.delete(variableEntryId);
+		}
 		this._onDidChangeContext.fire();
 	}
 
@@ -122,13 +124,15 @@ export class EditsAttachmentModel extends ChatAttachmentModel {
 		super.clear();
 	}
 
-	override delete(variableEntryId: string) {
-		const excludedFileIndex = this._excludedFileAttachments.findIndex(attachment => attachment.id === variableEntryId);
-		if (excludedFileIndex !== -1) {
-			this._excludedFileAttachments.splice(excludedFileIndex, 1);
+	override delete(...variableEntryIds: string[]) {
+		for (const variableEntryId of variableEntryIds) {
+			const excludedFileIndex = this._excludedFileAttachments.findIndex(attachment => attachment.id === variableEntryId);
+			if (excludedFileIndex !== -1) {
+				this._excludedFileAttachments.splice(excludedFileIndex, 1);
+			}
 		}
 
-		super.delete(variableEntryId);
+		super.delete(...variableEntryIds);
 
 		if (this.fileAttachments.length < this._chatEditingService.editingSessionFileLimit) {
 			const availableFileCount = Math.max(0, this._chatEditingService.editingSessionFileLimit - this.fileAttachments.length);

src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts

@@ -324,11 +324,9 @@ export class ChatEditingRemoveAllFilesAction extends Action2 {
 		// Remove all file attachments
 		const attachmentModel = chatWidget?.attachmentModel as EditsAttachmentModel | undefined;
 		const fileAttachments = attachmentModel ? [...attachmentModel.excludedFileAttachments, ...attachmentModel.fileAttachments] : [];
-		for (const uri of fileAttachments) {
-			if (URI.isUri(uri.value)) {
-				chatWidget?.attachmentModel.delete(uri.value.toString());
-			}
-		}
+
+		const attachmentIdsToRemove = fileAttachments.map(attachment => (attachment.value as URI).toString());
+		chatWidget?.attachmentModel.delete(...attachmentIdsToRemove);
 	}
 }
 registerAction2(ChatEditingRemoveAllFilesAction);