Skip to content

Commit

Permalink
v0.115 in xplat/js
Browse files Browse the repository at this point in the history
Summary:
https://our.intern.facebook.com/intern/wiki/Flow/Flow_Release_Process/Updating_Internal_Repositories/#update-xplat-js

reverted manually:
```
RKJSModules/Apps/Jobs/top_level_components/JobsCandidateDetailView.js
RKJSModules/Apps/MobileHome/ui/sevs/v2/MobileHomeSevsDetailsEscalationLogRow.js
RKJSModules/Apps/MobileHome/ui/sevs/v2/MobileHomeSevsDetailsHeaderMetadata.js
RKJSModules/Apps/MobileHome/ui/user/MobileHomeUserDetails.js
RKJSModules/Apps/Profile/ProfileEdit/apps/ProfileEditCollegeApp.js
RKJSModules/Apps/Profile/ProfileEdit/apps/ProfileEditWorkApp.js
metro/packages/metro/src/cli.js
RKJSModules/Apps/AdsLWI/Surfaces/AdsLWICallToActionEditorSurface.js
react-native-github/jest/preprocessor.js
```

Changelog: [Internal]

allow-large-files

Reviewed By: jbrown215

Differential Revision: D19292958

fbshipit-source-id: 4aa969bf2d0f2f5857e68a7e31ff4dcaf29e67cd
  • Loading branch information
panagosg7 authored and facebook-github-bot committed Jan 7, 2020
1 parent b4d5ffb commit 15ce226
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,4 @@ untyped-import
untyped-type-import

[version]
^0.114.0
^0.115.0
2 changes: 1 addition & 1 deletion .flowconfig.android
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,4 @@ untyped-import
untyped-type-import

[version]
^0.114.0
^0.115.0
3 changes: 3 additions & 0 deletions IntegrationTests/IntegrationTestsApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ class IntegrationTestsApp extends React.Component<{...}, $FlowFixMeState> {
<View style={styles.separator} />
<ScrollView>
{TESTS.map(test => [
/* $FlowFixMe(>=0.115.0 site=react_native_fb) This comment
* suppresses an error found when Flow v0.115 was deployed. To see
* the error, delete this comment and run Flow. */
<TouchableOpacity
onPress={() => this.setState({test})}
style={styles.row}>
Expand Down
4 changes: 0 additions & 4 deletions Libraries/Image/Image.android.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,8 @@ let Image = (props: ImagePropsType, forwardedRef) => {
let style;
let sources;
if (source?.uri != null) {
/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was found
* when making Flow check .android.js files. */
const {width, height} = source;
style = flattenStyle([{width, height}, styles.base, props.style]);
/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was found
* when making Flow check .android.js files. */
sources = [{uri: source.uri}];
} else {
style = flattenStyle([styles.base, props.style]);
Expand Down
12 changes: 12 additions & 0 deletions RNTester/js/examples/Image/ImageExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,9 @@ exports.examples = [
source={image}
/>
</View>
{/* $FlowFixMe(>=0.115.0 site=react_native_fb) This comment
* suppresses an error found when Flow v0.115 was deployed.
* To see the error, delete this comment and run Flow. */}
<View style={styles.leftMargin}>
<Text style={[styles.resizeModeText]}>Cover</Text>
<Image
Expand All @@ -801,6 +804,9 @@ exports.examples = [
source={image}
/>
</View>
{/* $FlowFixMe(>=0.115.0 site=react_native_fb) This comment
* suppresses an error found when Flow v0.115 was deployed.
* To see the error, delete this comment and run Flow. */}
<View style={styles.leftMargin}>
<Text style={[styles.resizeModeText]}>Repeat</Text>
<Image
Expand All @@ -809,6 +815,9 @@ exports.examples = [
source={image}
/>
</View>
{/* $FlowFixMe(>=0.115.0 site=react_native_fb) This comment
* suppresses an error found when Flow v0.115 was deployed.
* To see the error, delete this comment and run Flow. */}
<View style={styles.leftMargin}>
<Text style={[styles.resizeModeText]}>Center</Text>
<Image
Expand Down Expand Up @@ -860,6 +869,9 @@ exports.examples = [
{
title: 'Image Size',
render: function(): React.Node {
/* $FlowFixMe(>=0.115.0 site=react_native_fb) This comment suppresses an
* error found when Flow v0.115 was deployed. To see the error, delete
* this comment and run Flow. */
return <ImageSizeExample source={fullImage} />;
},
},
Expand Down
2 changes: 0 additions & 2 deletions RNTester/js/examples/TextInput/TextInputSharedExamples.js
Original file line number Diff line number Diff line change
Expand Up @@ -596,8 +596,6 @@ module.exports = ([
return (
<View>
<SelectionExample
/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was
* found when making Flow check .android.js files. */
style={styles.default}
value="text selection can be changed"
/>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
"eslint-plugin-react-hooks": "^2.0.1",
"eslint-plugin-react-native": "3.8.1",
"eslint-plugin-relay": "1.4.1",
"flow-bin": "^0.114.0",
"flow-bin": "^0.115.0",
"flow-remove-types": "1.2.3",
"jest": "^24.8.0",
"jest-junit": "^6.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ function combineSchemas(files: Array<string>): SchemaType {
const schema = FlowParser.parseFile(filename);

if (schema && schema.modules) {
/* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses
* an error found when Flow v0.111 was deployed. To see the error,
* delete this comment and run Flow. */
merged.modules = {...merged.modules, ...schema.modules};
}
}
Expand Down
2 changes: 1 addition & 1 deletion template/_flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ untyped-import
untyped-type-import

[version]
^0.114.0
^0.115.0
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3382,10 +3382,10 @@ flat-cache@^1.2.1:
rimraf "~2.6.2"
write "^0.2.1"

flow-bin@^0.114.0:
version "0.114.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.114.0.tgz#9079c5fcdf08fab4db91616f38994e9b7d035842"
integrity sha512-hewufX0nbnhemQn5XtJ97nEFNqoBclPBAZ54aY3jKuZJnLpwqB7Doaplet3M26TOh2NchBsU0+lUkM8oVna2VA==
flow-bin@^0.115.0:
version "0.115.0"
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.115.0.tgz#22e3ad9e5c7198967de80138ba8a9154ff387960"
integrity sha512-xW+U2SrBaAr0EeLvKmXAmsdnrH6x0Io17P6yRJTNgrrV42G8KXhBAD00s6oGbTTqRyHD0nP47kyuU34zljZpaQ==

flow-parser@0.*:
version "0.89.0"
Expand Down

0 comments on commit 15ce226

Please sign in to comment.