Remove shard node selector from hidden flags (rancher#2764)

That flag need not be hidden on cleanup and agent management commands, which parent command (`fleetcontroller`) does not define it. `fleetcontroller gitjob` defines it, where it therefore must not be hidden either.
sebastienmusso · Aug 29, 2024 · 849f739 · 849f739
1 parent d375967
commit 849f739
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/internal/cmd/controller/agentmanagement/root.go b/internal/cmd/controller/agentmanagement/root.go
@@ -22,7 +22,6 @@ type AgentManagement struct {
 func (a *AgentManagement) HelpFunc(cmd *cobra.Command, strings []string) {
 	_ = cmd.Flags().MarkHidden("disable-metrics")
 	_ = cmd.Flags().MarkHidden("shard-id")
-	_ = cmd.Flags().MarkHidden("shard-node-selector")
 	cmd.Parent().HelpFunc()(cmd, strings)
 }
 

diff --git a/internal/cmd/controller/cleanup/root.go b/internal/cmd/controller/cleanup/root.go
@@ -17,7 +17,6 @@ type CleanUp struct {
 func (c *CleanUp) HelpFunc(cmd *cobra.Command, strings []string) {
 	_ = cmd.Flags().MarkHidden("disable-metrics")
 	_ = cmd.Flags().MarkHidden("shard-id")
-	_ = cmd.Flags().MarkHidden("shard-node-selector")
 	cmd.Parent().HelpFunc()(cmd, strings)
 }
 

diff --git a/internal/cmd/controller/gitops/operator.go b/internal/cmd/controller/gitops/operator.go
@@ -68,7 +68,6 @@ func App(zo *zap.Options) *cobra.Command {
 func (c *GitOperator) HelpFunc(cmd *cobra.Command, strings []string) {
 	_ = cmd.Flags().MarkHidden("disable-metrics")
 	_ = cmd.Flags().MarkHidden("shard-id")
-	_ = cmd.Flags().MarkHidden("shard-node-selector")
 	cmd.Parent().HelpFunc()(cmd, strings)
 }