Merge pull request jxcore#10 from cleancoderocker/master

Added type check of callback parameter.
seckin · May 26, 2014 · b24c658 · b24c658
2 parents c2624bb + 756a3d9
commit b24c658
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/backend/jx_helpers.js b/backend/jx_helpers.js
@@ -28,11 +28,14 @@ exports.store = {
 };
 
 exports.addEvent = function (event, cb) {
-    if (!events[event]) {
-        events[event] = [];
+    if(typeof cb === "function") {
+        if (!events[event]) {
+            events[event] = [];
+        }
+        events[event].push(cb);
+    } else {
+        throw new TypeError("Callback is not a function.");
     }
-
-    events[event].push(cb);
 };
 
 exports.emitEvent = function (event, param1, param2, param3) {

diff --git a/backend/jxm.js b/backend/jxm.js
@@ -392,7 +392,11 @@ exports.setEngine = function (app) {
  * @param listener {function} - Callback function which will be invoked upon emit of the event.
  */
 exports.on = function (event, listener) {
-    helpers.addEvent(event, listener);
+    if(typeof listener === "function") {
+        helpers.addEvent(event, listener);
+    } else {
+        throw new TypeError("Listener is not a function.");
+    }
 };