Handle some shortcuts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
handle-some-shortcuts
branch
from
3c7e3af to
6c50872
Compare
`key` is supported, therefore for consistency resons `[index]` should be supported too. This is not required from the "standard" but I think that it is an useful addition. This change will also add support to `.key` syntax as a side effect.
We added [index] support for consistency, however due to my personal laziness .key is accepted as a side effect of this change. Most implementations, except the implementation used by kubectl, do not support it, however I think it will not introduce any unexpected drawback. I added it to the tests since we want to keep this library as stable as possible, even for unexpected features.
bettio
force-pushed
the
handle-some-shortcuts
branch
from
6c50872 to
3663688
Compare
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 1 1
Lines 22 22
=======================================
Hits 21 21
Misses 1 1 Continue to review full report at Codecov.
|
rbino
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to
[index]syntax.