Skip to content

Commit

Permalink
KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko
Browse files Browse the repository at this point in the history
make allmodconfig && make W=1 C=1 reports for lib/test_*.ko:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hexdump.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_dhry.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_firmware.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sysctl.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_hash.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ida.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_list_sort.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_min_heap.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_module.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_sort.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_keys.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_static_key_base.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_memcat_p.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_blackhole_dev.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_meminit.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_free_pages.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kprobes.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_ref_tracker.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bits.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Jeff Johnson <[email protected]>
Reviewed-by: Kees Cook <[email protected]>
Reviewed-by: Masami Hiramatsu (Google) <[email protected]>
Cc: Anil S Keshavamurthy <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Masami Hiramatsu (Google) <[email protected]>
Cc: "Naveen N. Rao" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
Jeff Johnson authored and akpm00 committed Jun 25, 2024
1 parent d2917ff commit 3034749
Show file tree
Hide file tree
Showing 20 changed files with 22 additions and 2 deletions.
1 change: 1 addition & 0 deletions lib/dhry_run.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,5 @@ static int __init dhry_init(void)
module_init(dhry_init);

MODULE_AUTHOR("Geert Uytterhoeven <[email protected]>");
MODULE_DESCRIPTION("Dhrystone benchmark test module");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test-kstrtox.c
Original file line number Diff line number Diff line change
Expand Up @@ -732,4 +732,5 @@ static int __init test_kstrtox_init(void)
return -EINVAL;
}
module_init(test_kstrtox_init);
MODULE_DESCRIPTION("Module test for kstrto*() APIs");
MODULE_LICENSE("Dual BSD/GPL");
1 change: 1 addition & 0 deletions lib/test_bits.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,5 @@ static struct kunit_suite bits_test_suite = {
};
kunit_test_suite(bits_test_suite);

MODULE_DESCRIPTION("Test cases for functions and macros in bits.h");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_blackhole_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,5 @@ module_init(test_blackholedev_init);
module_exit(test_blackholedev_exit);

MODULE_AUTHOR("Mahesh Bandewar <[email protected]>");
MODULE_DESCRIPTION("module test of the blackhole_dev");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_firmware.c
Original file line number Diff line number Diff line change
Expand Up @@ -1567,4 +1567,5 @@ static void __exit test_firmware_exit(void)
module_exit(test_firmware_exit);

MODULE_AUTHOR("Kees Cook <[email protected]>");
MODULE_DESCRIPTION("interface to trigger and test firmware loading");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_free_pages.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ static void m_ex(void)
module_init(m_in);
module_exit(m_ex);
MODULE_AUTHOR("Matthew Wilcox <[email protected]>");
MODULE_DESCRIPTION("Check that free_pages() doesn't leak memory");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,4 +235,5 @@ static struct kunit_suite hash_test_suite = {

kunit_test_suite(hash_test_suite);

MODULE_DESCRIPTION("Test cases for <linux/hash.h> and <linux/stringhash.h>");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_hexdump.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,4 +253,5 @@ static void __exit test_hexdump_exit(void)
module_exit(test_hexdump_exit);

MODULE_AUTHOR("Andy Shevchenko <[email protected]>");
MODULE_DESCRIPTION("Test cases for lib/hexdump.c module");
MODULE_LICENSE("Dual BSD/GPL");
1 change: 1 addition & 0 deletions lib/test_ida.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,5 @@ static void ida_exit(void)
module_init(ida_checks);
module_exit(ida_exit);
MODULE_AUTHOR("Matthew Wilcox <[email protected]>");
MODULE_DESCRIPTION("Test the IDA API");
MODULE_LICENSE("GPL");
3 changes: 2 additions & 1 deletion lib/test_kprobes.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* test_kprobes.c - simple sanity test for *probes
* test_kprobes.c - simple sanity test for k*probes
*
* Copyright IBM Corp. 2008
*/
Expand Down Expand Up @@ -400,4 +400,5 @@ static struct kunit_suite kprobes_test_suite = {

kunit_test_suites(&kprobes_test_suite);

MODULE_DESCRIPTION("simple sanity test for k*probes");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_list_sort.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,5 @@ static struct kunit_suite list_sort_suite = {

kunit_test_suites(&list_sort_suite);

MODULE_DESCRIPTION("list_sort() KUnit test suite");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_memcat_p.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,5 @@ static void __exit test_memcat_p_exit(void)
module_init(test_memcat_p_init);
module_exit(test_memcat_p_exit);

MODULE_DESCRIPTION("Test cases for memcat_p() in lib/memcat_p.c");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_meminit.c
Original file line number Diff line number Diff line change
Expand Up @@ -436,4 +436,5 @@ static int __init test_meminit_init(void)
}
module_init(test_meminit_init);

MODULE_DESCRIPTION("Test cases for SL[AOU]B/page initialization at alloc/free time");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_min_heap.c
Original file line number Diff line number Diff line change
Expand Up @@ -226,4 +226,5 @@ static void __exit test_min_heap_exit(void)
}
module_exit(test_min_heap_exit);

MODULE_DESCRIPTION("Test cases for the min max heap");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ static void __exit test_module_exit(void)
module_exit(test_module_exit);

MODULE_AUTHOR("Kees Cook <[email protected]>");
MODULE_DESCRIPTION("module loading subsystem test module");
MODULE_LICENSE("GPL");
3 changes: 2 additions & 1 deletion lib/test_ref_tracker.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
* Referrence tracker self test.
* Reference tracker self test.
*
* Copyright (c) 2021 Eric Dumazet <[email protected]>
*/
Expand Down Expand Up @@ -112,4 +112,5 @@ static void __exit test_ref_tracker_exit(void)
module_init(test_ref_tracker_init);
module_exit(test_ref_tracker_exit);

MODULE_DESCRIPTION("Reference tracker self test");
MODULE_LICENSE("GPL v2");
1 change: 1 addition & 0 deletions lib/test_sort.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,5 @@ static struct kunit_suite sort_test_suite = {

kunit_test_suites(&sort_test_suite);

MODULE_DESCRIPTION("sort() KUnit test suite");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_static_key_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,5 @@ module_init(test_static_key_base_init);
module_exit(test_static_key_base_exit);

MODULE_AUTHOR("Jason Baron <[email protected]>");
MODULE_DESCRIPTION("Kernel module to support testing static keys");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_static_keys.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,4 +236,5 @@ module_init(test_static_key_init);
module_exit(test_static_key_exit);

MODULE_AUTHOR("Jason Baron <[email protected]>");
MODULE_DESCRIPTION("Kernel module for testing static keys");
MODULE_LICENSE("GPL");
1 change: 1 addition & 0 deletions lib/test_sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -280,4 +280,5 @@ static void __exit test_sysctl_exit(void)
module_exit(test_sysctl_exit);

MODULE_AUTHOR("Luis R. Rodriguez <[email protected]>");
MODULE_DESCRIPTION("proc sysctl test driver");
MODULE_LICENSE("GPL");

0 comments on commit 3034749

Please sign in to comment.