Skip to content

Commit

Permalink
ext4: Reduce ext4 timestamp warnings
Browse files Browse the repository at this point in the history
When ext4 file systems were created intentionally with 128 byte inodes,
the rate-limited warning of eventual possible timestamp overflow are
still emitted rather frequently.  Remove the warning for now.

Discussion for whether any warning is needed,
and where it should be emitted, can be found at
https://lore.kernel.org/lkml/[email protected]/.
I can post a separate follow-up patch after the conclusion.

Reported-by: Qian Cai <[email protected]>
Signed-off-by: Deepa Dinamani <[email protected]>
Reviewed-by: Andreas Dilger <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
  • Loading branch information
deepa-hub authored and arndb committed Sep 4, 2019
1 parent 9d14545 commit cba465b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions fs/ext4/ext4.h
Original file line number Diff line number Diff line change
Expand Up @@ -833,10 +833,8 @@ do { \
(raw_inode)->xtime ## _extra = \
ext4_encode_extra_time(&(inode)->xtime); \
} \
else {\
else \
(raw_inode)->xtime = cpu_to_le32(clamp_t(int32_t, (inode)->xtime.tv_sec, S32_MIN, S32_MAX)); \
ext4_warning_inode(inode, "inode does not support timestamps beyond 2038"); \
} \
} while (0)

#define EXT4_EINODE_SET_XTIME(xtime, einode, raw_inode) \
Expand Down

0 comments on commit cba465b

Please sign in to comment.