Skip to content

Commit

Permalink
lockd: Remove unnecessary memset()
Browse files Browse the repository at this point in the history
Since commit 103cc1f ("SUNRPC: Parametrize how much of argsize
should be zeroed") (and possibly long before that, even) all of the
memory underlying rqstp->rq_argp is zeroed already. There's no need
for the memset() in nlm4svc_decode_shareargs().

Reviewed-by: Jeff Layton <[email protected]>
Reviewed-by: NeilBrown <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
  • Loading branch information
chucklever committed Nov 19, 2024
1 parent 2f746e4 commit e594884
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/lockd/xdr4.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ nlm4svc_decode_shareargs(struct svc_rqst *rqstp, struct xdr_stream *xdr)
struct nlm_args *argp = rqstp->rq_argp;
struct nlm_lock *lock = &argp->lock;

memset(lock, 0, sizeof(*lock));
locks_init_lock(&lock->fl);
lock->svid = ~(u32)0;

Expand Down

0 comments on commit e594884

Please sign in to comment.