Update Google Fonts #217
Merged
Update Google Fonts #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a0d5bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
michaeltaranto
approved these changes
Nov 13, 2024
Merged
devjiwonchoi
added a commit
to vercel/next.js
that referenced
this pull request
Nov 13, 2024
### Why? `next/font` depends on the Google Fonts metrics from the `@capsizecss/metrics`. Added support for Geist at seek-oss/capsize#217, so we update version. ### How? - Bump `@capsizecss/metrics` to 3.4.0 - Update the test to match the metrics. #### Bonus - Modified the test to use `.toMatchInlineSnapshot` to identify and update future changes more easily. ### RFC The `@capsizecss` team is planning to [automate the updating process](seek-oss/capsize#217 (review)). Should we continue to depend on them or replace them with our custom script to fetch Google Font API (requires API key)? x-ref: #47115 x-ref: [Twitter Feedback](https://x.com/illyism/status/1855500917589602706)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The New Google Font
Geistis out, and it would be great to add support for it in@capsize/metricsas Next.jsnext/fontis currently depending on it. 😌