[AST Verifier] Don't deserialize protocol conformances just to verify…

… them. Fixes rdar://problem/24922889.
sefdeni · Mar 2, 2016 · 659811e · 659811e
1 parent 0fe865a
commit 659811e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/include/swift/AST/ProtocolConformance.h b/include/swift/AST/ProtocolConformance.h
@@ -415,6 +415,11 @@ class NormalProtocolConformance : public ProtocolConformance,
     ContextAndInvalid.setInt(true);
   }
 
+  /// Determine whether this conformance is lazily resolved.
+  ///
+  /// This only matters to the AST verifier.
+  bool isLazilyResolved() const { return Resolver != nullptr; }
+
   /// True if the conformance describes a property behavior.
   bool isBehaviorConformance() const {
     return ContextAndInvalid.getPointer().is<AbstractStorageDecl *>();

diff --git a/lib/AST/ASTVerifier.cpp b/lib/AST/ASTVerifier.cpp
@@ -1734,6 +1734,10 @@ struct ASTNodeBase {};
       if (!normal)
         return;
 
+      // If the conformance is lazily resolved, don't check it; that can cause
+      // massive deserialization at a point where the compiler cannot handle it.
+      if (normal->isLazilyResolved()) return;
+
       // Translate the owning declaration into a DeclContext.
       NominalTypeDecl *nominal = dyn_cast<NominalTypeDecl>(decl);
       DeclContext *conformingDC;