v3: add WIP chrome headless implementation (#1225) #1528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial chrome interface * base chrome class on EventEmitter, disable gpu by default * initial structure for Nightmare class, extending Chrome interface * add xo for linting and adapt example script to new interface * actions integration * evaluation work * fix js evaluation * js evaluation error handling * fix javascript evaluation * type action * debug network requests * fix dispatchKeyEvent in type action * pass headless switch to chrome class * tidy up logging, end chrome process fixes * fix result output * wait for chrome process to start * better chrome connection handling * revert from class interface and some es6+ features, for node 4+ * test fixes/updates * response data * test fixes * better handling (and logging) of chrome communication errors * goto fixes when dom loaded * inject javascript * inject css * pass through console calls to nightmare * tweak chrome console output * remove unnecessary escape characters in css injector * console event fixes * test fixes * fixes and initial cookie work * cookie fixes * fix screenshots * fix screenshots and html * fix pdf * fix useragent * events * additional test fixes * tidy up * remove ipc * chrome fix for node <8 * process fixes * url fixes * multiple fixes * additional fixes * syntax fixes for node 4 * node 4 fixes * re-add xo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial chrome interface
base chrome class on EventEmitter, disable gpu by default
initial structure for Nightmare class, extending Chrome interface
add xo for linting and adapt example script to new interface
actions integration
evaluation work
fix js evaluation
js evaluation error handling
fix javascript evaluation
type action
debug network requests
fix dispatchKeyEvent in type action
pass headless switch to chrome class
tidy up logging, end chrome process fixes
fix result output
wait for chrome process to start
better chrome connection handling
revert from class interface and some es6+ features, for node 4+
test fixes/updates
response data
test fixes
better handling (and logging) of chrome communication errors
goto fixes when dom loaded
inject javascript
inject css
pass through console calls to nightmare
tweak chrome console output
remove unnecessary escape characters in css injector
console event fixes
test fixes
fixes and initial cookie work
cookie fixes
fix screenshots
fix screenshots and html
fix pdf
fix useragent
events
additional test fixes
tidy up
remove ipc
chrome fix for node <8
process fixes
url fixes
multiple fixes
additional fixes
syntax fixes for node 4
node 4 fixes
re-add xo