Add .authentication() #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,6 +104,9 @@ Saves a screenshot of the current page to the specified `path`. Useful for debug | |||
| #### .useragent(useragent) | |||
| Set the `useragent` used by PhantomJS. | |||
|
|
|||
| #### .authentication(userName, password) | |||
There was a problem hiding this comment.
would prefer to stick with one-word parameters like user
|
rockin test! naming nit and then if you could rebase to master so that i can merge? thanks man, great additions! |
|
can you rebase to master and squash to a single commit? https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request |
|
related to #45 |
|
Merged, but I've somehow managed to make things worse commit message wise. I'll have to ask a guy with more git-fu for help when he comes in tomorrow. |
|
This request's git history is fubar. I'm going to close and reopen with a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .authentication(userName,password) method for basic http auth. Updated readme & tests.