Skip to content

Commit

Permalink
Revert "MDL-33303 Filepicker: resized to match HTML editor and made r…
Browse files Browse the repository at this point in the history 
…esizable"

This reverts commit c947ea3.
  • Loading branch information
@stronk7
stronk7 committed Jul 5, 2012
1 parent 2fba8f5 commit ecad739
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 67 deletions.
17 changes: 3 additions & 14 deletions files/renderer.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function render_form_filemanager($fm) {
$module = array(
'name'=>'form_filemanager',
'fullpath'=>'/lib/form/filemanager.js',
'requires' => array('core_filepicker', 'base', 'io-base', 'node', 'json', 'core_dndupload', 'panel', 'resize-plugin', 'dd-plugin', 'resize'),
'requires' => array('core_filepicker', 'base', 'io-base', 'node', 'json', 'core_dndupload', 'panel', 'resize-plugin', 'dd-plugin'),
'strings' => array(
array('error', 'moodle'), array('info', 'moodle'), array('confirmdeletefile', 'repository'),
array('draftareanofiles', 'repository'), array('entername', 'repository'), array('enternewname', 'repository'),
Expand All @@ -123,7 +123,6 @@ public function render_form_filemanager($fm) {
array($this->filemanager_js_templates()), true, $module);
}
$this->page->requires->js_init_call('M.form_filemanager.init', array($fm->options), true, $module);
user_preference_allow_ajax_update('filemanagerresizedto', PARAM_SEQUENCE);

// non javascript file manager
$html .= '<noscript>';
Expand Down Expand Up @@ -193,17 +192,8 @@ private function fm_print_generallayout($fm) {
$strdndenabledinbox = get_string('dndenabled_inbox', 'moodle');
$loading = get_string('loading', 'repository');

$resizedto = get_user_preferences('filemanagerresizedto', null);
$filemanagerstyle = '';
$containerstyletag = '';
if (!is_null($resizedto) && preg_match('#^\d+,\d+$#', $resizedto)) {
list($width, $height) = explode(',', $resizedto, 2);
$filemanagerstyle = " style='width:{$width}px;'";
$containerstyletag = " style='height:{$height}px;'";
}

$html = '
<div id="filemanager-'.$client_id.'" class="filemanager fm-loading"'.$filemanagerstyle.'>
<div id="filemanager-'.$client_id.'" class="filemanager fm-loading">
<div class="fp-restrictions">
'.$restrictions.'
<span class="dndupload-message"> - '.$strdndenabled.' </span>
Expand All @@ -226,7 +216,7 @@ private function fm_print_generallayout($fm) {
</div>
</div>
<div class="filemanager-loading mdl-align">'.$icon_progress.'</div>
<div class="filemanager-container"'.$containerstyletag.'>
<div class="filemanager-container" >
<div class="fm-content-wrapper">
<div class="fp-content"></div>
<div class="fm-empty-container">
Expand All @@ -237,7 +227,6 @@ private function fm_print_generallayout($fm) {
</div>
<div class="filemanager-updating">'.$icon_progress.'</div>
</div>
<div class="fp-statusbar"></div>
</div>';
return preg_replace('/\{\!\}/', '', $html);
}
Expand Down
51 changes: 2 additions & 49 deletions lib/form/filemanager.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,6 @@ M.form_filemanager.init = function(Y, options) {
} else {
this.filecount = 0;
}

this.publish('filemanager:content-changed', {
context : this,
prefix : 'filemanager',
preventable : false,
type : 'content-changed'
});

// prepare filemanager for drag-and-drop upload
this.filemanager = Y.one('#filemanager-'+options.client_id);
if (this.filemanager.hasClass('filemanager-container') || !this.filemanager.one('.filemanager-container')) {
Expand Down Expand Up @@ -130,44 +122,6 @@ M.form_filemanager.init = function(Y, options) {
this.filemanager.all('.fp-vb-icons,.fp-vb-tree,.fp-vb-details').removeClass('checked')
this.filemanager.all('.fp-vb-icons').addClass('checked')
this.refresh(this.currentpath); // MDL-31113 get latest list from server

// Make sure that the filemanager is at least shown within the constraints of the page
if ((this.filemanager.get('offsetWidth') + this.filemanager.getX()) > this.filemanager.get('docWidth')) {
this.filemanager.setStyle('width', Math.round(this.filemanager.get('docWidth') - this.filemanager.getX()));
}

if (Y.Resize) {
// We only do this is the YUI resize component is loaded
var resize = new Y.Resize({
node: this.dndcontainer,
wrap : true,
handles : ['br']
}).plug(Y.Plugin.ResizeConstrained, {
minWidth : 410,
maxWidth : this.dndcontainer.ancestor('.ffilemanager').get('offsetWidth') || 1600,
minHeight : 160,
maxHeight : 1024
});
// When it resizes we need to correct the width and height of other elements.
resize.on('resize:resize', function(e) {
this.filemanager.setStyle('width', e.info.offsetWidth);
var fmcw = this.filemanager.one('.fp-content');
if (fmcw) {
fmcw.setStyle('height', this.dndcontainer.get('offsetHeight'));
}
}, this);
// After resizing we update the user preference so that we always show them the file manager at the same size.
resize.on('resize:end', function(e){
M.util.set_user_preference('filemanagerresizedto', Math.round(e.info.offsetWidth).toString()+','+Math.round(e.info.offsetHeight).toString());
});
// When content gets updated by the filemanager we need to auto-update the height of the resizeable area to include it.
this.on('filemanager:content-changed', function(){
var fmcw = this.filemanager.one('.fp-content');
if (fmcw) {
fmcw.setStyle('height', this.dndcontainer.get('offsetHeight'));
}
}, this);
}
},

wait: function() {
Expand Down Expand Up @@ -557,15 +511,15 @@ M.form_filemanager.init = function(Y, options) {
filenode : element_template,
callbackcontext : this,
callback : function(e, node) {
if (e.preventDefault) {e.preventDefault();}
if (e.preventDefault) { e.preventDefault(); }
if (node.type == 'folder') {
this.refresh(node.filepath);
} else {
this.select_file(node);
}
},
rightclickcallback : function(e, node) {
if (e.preventDefault) {e.preventDefault();}
if (e.preventDefault) { e.preventDefault(); }
this.select_file(node);
},
classnamecallback : function(node) {
Expand Down Expand Up @@ -652,7 +606,6 @@ M.form_filemanager.init = function(Y, options) {
node.appendChild(Y.Node.create('<option/>').
set('value', list[i]).setContent(list[i]))
}
this.fire('filemanager:content-changed');
},
update_file: function(confirmed) {
var selectnode = this.selectnode;
Expand Down
6 changes: 2 additions & 4 deletions theme/base/style/filemanager.css
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* File Picker and File Manager
*/
.filemanager {width: 680px; min-width: 410px;}

.filemanager, .file-picker {font-size:11px;color: #555555;letter-spacing: .2px;}
.filemanager a, .file-picker a {color:#555555;}
.filemanager a:hover, .file-picker a:hover {color:#555555;text-decoration: none;}
Expand Down Expand Up @@ -290,10 +290,8 @@ a.ygtvspacer:hover {color: transparent;text-decoration: none;}
/*.filemanager-container ul{margin:0;padding:0;}
.filemanager-container ul li{white-space:nowrap;list-style-type:none;}
.filemanager-container ul li a{padding:0}*/
.filemanager .fp-content{overflow: auto;}
.filemanager .fp-content{overflow: auto;max-height: 472px;}
.filemanager-container, .filepicker-filelist {overflow:hidden;}
.filemanager.fm-loaded .fp-statusbar {background: #F2F2F2;border: 1px solid #BBB;border-top:0;min-height:2em;margin-bottom:5px;padding-right:2em;}
.filemanager .yui3-resize-handle-inner-br {bottom:-2em;}

/*
* Icon view (File Manager only)
Expand Down

0 comments on commit ecad739

Please sign in to comment.