Skip to content

Commit

Permalink
regulator: If we can't configure optimum mode we're always in the bes…
Browse files Browse the repository at this point in the history
…t one

If either a regulator driver can't tell us what the optimum mode is (or
doesn't have modes in the first place) or the system doesn't allow DRMS
changes then it's more helpful for users to just say that we're in the
optimal mode, even if it's from a selection of one.

Still report errors if the process of picking and setting a mode changes as
this may indicate that we're stuck in a low power mode and unable to deliver
a higher current that the consumer just asked for.

Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Liam Girdwood <[email protected]>
  • Loading branch information
broonie authored and Liam Girdwood committed May 27, 2011
1 parent afdaaaf commit a4b4148
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions drivers/regulator/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2097,16 +2097,26 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load)

mutex_lock(&rdev->mutex);

/*
* first check to see if we can set modes at all, otherwise just
* tell the consumer everything is OK.
*/
regulator->uA_load = uA_load;
ret = regulator_check_drms(rdev);
if (ret < 0)
if (ret < 0) {
ret = 0;
goto out;
ret = -EINVAL;
}

/* sanity check */
if (!rdev->desc->ops->get_optimum_mode)
goto out;

/*
* we can actually do this so any errors are indicators of
* potential real failure.
*/
ret = -EINVAL;

/* get output voltage */
output_uV = _regulator_get_voltage(rdev);
if (output_uV <= 0) {
Expand Down

0 comments on commit a4b4148

Please sign in to comment.