Skip to content

Commit

Permalink
regulator: MAX8997: Fix for divide by zero error
Browse files Browse the repository at this point in the history
Currently, ramp_delay variable is used uninitialzed in
max8997_set_voltage_ldobuck which gets called through
regulator_register calls.

To fix the problem, in max8997_pmic_probe, ramp_delay initialization
code is moved before calls to regulator_register.

Cc: Liam Girdwood <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: MyungJoo Ham <[email protected]>
Cc: Kyungmin Park <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Signed-off-by: Tushar Behera <[email protected]>
Acked-by: MyungJoo Ham <[email protected]>
Acked-by: Mark Brown <[email protected]>
Signed-off-by: Liam Girdwood <[email protected]>
  • Loading branch information
Tushar Behera authored and Liam Girdwood committed Jul 8, 2011
1 parent e2cf313 commit dbb48e7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/regulator/max8997.c
Original file line number Diff line number Diff line change
Expand Up @@ -1124,6 +1124,10 @@ static __devinit int max8997_pmic_probe(struct platform_device *pdev)
0x3f);
}

/* Misc Settings */
max8997->ramp_delay = 10; /* set 10mV/us, which is the default */
max8997_write_reg(i2c, MAX8997_REG_BUCKRAMP, (0xf << 4) | 0x9);

for (i = 0; i < pdata->num_regulators; i++) {
const struct voltage_map_desc *desc;
int id = pdata->regulators[i].id;
Expand All @@ -1148,10 +1152,6 @@ static __devinit int max8997_pmic_probe(struct platform_device *pdev)
}
}

/* Misc Settings */
max8997->ramp_delay = 10; /* set 10mV/us, which is the default */
max8997_write_reg(i2c, MAX8997_REG_BUCKRAMP, (0xf << 4) | 0x9);

return 0;
err:
for (i = 0; i < max8997->num_regulators; i++)
Expand Down

0 comments on commit dbb48e7

Please sign in to comment.