selftest: Fail testsuite on unknown environment

The status quo was that tests in typo'd/unknown environments would be skipped. This was a side effect of the mechanism by which samba3 tests were run, which has now been changed. For an example of this being a problem in the past, see commit 523bd03 (which fixes an issue I noticed when reading subunit logs, and which did not fail the test). Signed-off-by: Jamie McClymont <[email protected]> Reviewed-by: Andrew Bartlett <[email protected]> Reviewed-by: Douglas Bagnall <[email protected]>
selsky · Feb 24, 2018 · 3b0a940 · 3b0a940
1 parent 5ad5e79
commit 3b0a940
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/selftest/selftest.pl b/selftest/selftest.pl
@@ -1117,8 +1117,8 @@ ($)
 			next;
 		} elsif ($envvars eq "UNKNOWN") {
 			Subunit::start_testsuite($name);
-			Subunit::end_testsuite($name, "skip",
-				"environment $envname is unknown in this test backend - skipping");
+			Subunit::end_testsuite($name, "error",
+				"environment $envname is unknown - exiting");
 			next;
 		}