winbind: avoid using fstrcpy(dcname,...) in _dual_init_connection

domain->dcname was converted from fstring to char * by commit 14bae61. Luckily this was only ever called with an empty string in state->request->data.init_conn.dcname. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13294 Signed-off-by: Stefan Metzmacher <[email protected]>
selsky · Feb 23, 2018 · d73e3d4 · d73e3d4
1 parent b158d4e
commit d73e3d4
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/source3/winbindd/winbindd_util.c b/source3/winbindd/winbindd_util.c
@@ -781,7 +781,12 @@ enum winbindd_result winbindd_dual_init_connection(struct winbindd_domain *domai
 		[sizeof(state->request->data.init_conn.dcname)-1]='\0';
 
 	if (strlen(state->request->data.init_conn.dcname) > 0) {
-		fstrcpy(domain->dcname, state->request->data.init_conn.dcname);
+		TALLOC_FREE(domain->dcname);
+		domain->dcname = talloc_strdup(domain,
+				state->request->data.init_conn.dcname);
+		if (domain->dcname == NULL) {
+			return WINBINDD_ERROR;
+		}
 	}
 
 	init_dc_connection(domain, false);