Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support previous root collections & roles. #2687

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

svennd
Copy link

@svennd svennd commented Jan 9, 2025

This would allow the previous behaviour aswell as the new behaviour : (issue #2519)

Currently allowed :

<playbook_dir>/collections/requirements.yml
<playbook_dir>/roles/requirements.yml

suggested change :

<playbook_dir>/collections/requirements.yml
<playbook_dir>/roles/requirements.yml
<repo_dir>/collections/requirements.yml
<repo_dir>/roles/requirements.yml

This makes it possible to utilise subdir's to put the playbooks in, sharing a common role or collection. Eg :

/collections/requirements.yml
/debug/play_tester.yml
/maintain/play_maintenance_a.yml
/maintain/play_maintenance_b.yml

this makes more sense to maintain then :

/debug/collections/requirements.yml
/debug/play_tester.yml

/maintain/collections/requirements.yml
/maintain/play_maintenance_a.yml
/maintain/play_maintenance_b.yml

A more proper way might be possible!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tinyoverflow
Copy link
Contributor

tinyoverflow commented Feb 4, 2025

Yes, please. I've already fixed this in May 2024, but now this was changed again. And it wasn't even mentioned in the changelogs. It was driving me nuts, as some of my playbooks depending on third-party collections won't run anymore after an update and putting them inside my playbook directory (which is not the root of my ansible repository) is more like a workaround from my perspective.

@fiftin please look at this, as your previous change from 05e0723 broke some repository setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants