fix rubocop errors

.rubocop.yml

@@ -1,4 +1,3 @@
-
 Metrics/MethodLength:
   Max: 200
 
@@ -143,4 +142,83 @@ Style/SlicingWithRange:
 Style/StringConcatenation:
   Enabled: false
 
+Layout/SpaceBeforeBrackets:
+  Enabled: true
+
+Lint/AmbiguousAssignment:
+  Enabled: true
+
+Lint/DeprecatedConstants:
+  Enabled: true
+
+Lint/DuplicateBranch:
+  Enabled: true
+
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
+Lint/EmptyBlock:
+  Enabled: true
+
+Lint/EmptyClass:
+  Enabled: true
+
+Lint/LambdaWithoutLiteralBlock:
+  Enabled: true
+
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
+
+Lint/NumberedParameterAssignment:
+  Enabled: true
+
+Lint/OrAssignmentToConstant:
+  Enabled: true
+
+Lint/RedundantDirGlobSort:
+  Enabled: true
+
+Lint/SymbolConversion:
+  Enabled: true
+
+Lint/ToEnumArguments:
+  Enabled: true
+
+Lint/TripleQuotes:
+  Enabled: true
+
+Lint/UnexpectedBlockArity:
+  Enabled: true
+
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+
+Style/ArgumentsForwarding:
+  Enabled: true
+
+Style/CollectionCompact:
+  Enabled: true
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
+
+Style/EndlessMethod:
+  Enabled: true
+
+Style/HashExcept:
+  Enabled: true
+
+Style/IfWithBooleanLiteralBranches:
+  Enabled: true
+
+Style/NegatedIfElseCondition:
+  Enabled: true
+
+Style/NilLambda:
+  Enabled: true
+
+Style/RedundantArgument:
+  Enabled: true
 
+Style/SwapValues:
+  Enabled: true

Rakefile

@@ -13,8 +13,7 @@ ENV['TZ'] = 'CET'
 args = %i[spec make_bin_executable yard rubocop check_binstubs]
 
 YARD::Rake::YardocTask.new do |t|
-  OTHER_PATHS = %w[].freeze
-  t.files = ['lib/**/*.rb', 'bin/**/*.rb', OTHER_PATHS]
+  t.files = ['lib/**/*.rb', 'bin/**/*.rb']
   t.options = %w[--markup-provider=redcarpet --markup=markdown --main=README.md --files CHANGELOG.md]
 end
 

bin/check-ssl-cert.rb

@@ -97,10 +97,10 @@ def validate_opts
     elsif config[:pem]
       unknown 'No such cert' unless File.exist? config[:pem]
     elsif config[:pkcs12]
-      if !config[:pass]
-        unknown 'No pass phrase specified for PKCS#12 certificate'
-      else
+      if config[:pass]
         unknown 'No such cert' unless File.exist? config[:pkcs12]
+      else
+        unknown 'No pass phrase specified for PKCS#12 certificate'
       end
     end
     config[:servername] = config[:host] unless config[:servername]

bin/check-ssl-root-issuer.rb

@@ -68,7 +68,7 @@ class CheckSSLRootIssuer < Sensu::Plugin::Check::CLI
          required: false
 
   def cert_name_format
-    # Note: because format argument is pre-validated by mixin 'in' logic eval is safe to use
+    # NOTE: because format argument is pre-validated by mixin 'in' logic eval is safe to use
     eval "OpenSSL::X509::Name::#{config[:format]}" # rubocop:disable Security/Eval, Style/EvalWithLocation
   end
 
@@ -100,7 +100,7 @@ def find_root_cert(uri)
       end
       verify_ok
     }
-    http.start {}
+    http.start
     root_cert
   end