rating MDL-21657 changed ratings rendering to avoid a nonconstant ele…

…ment name
sergio91pt · Mar 19, 2010 · c82ed0a · c82ed0a
1 parent 5bdf001
commit c82ed0a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php
@@ -1320,7 +1320,7 @@ function render_rating(rating $rating) {
             }
 
             $scalearray = array(RATING_UNSET_RATING => $strrate.'...') + $scalearray;
-            $strratings .= html_writer::select($scalearray, 'rating'.$rating->itemid, $rating->rating, false, array('class'=>'postratingmenu ratinginput'));
+            $strratings .= html_writer::select($scalearray, 'rating', $rating->rating, false, array('class'=>'postratingmenu ratinginput','id'=>'menurating'.$rating->itemid));
 
             //output submit button
             $strratings .= '<span class="ratingsubmit"><input type="submit" class="postratingmenusubmit" id="postratingsubmit'.$rating->itemid.'" value="'.s(get_string('rate', 'rating')).'" />';

diff --git a/rating/rate.php b/rating/rate.php
@@ -34,7 +34,7 @@
 $contextid = required_param('contextid', PARAM_INT);
 $itemid = required_param('itemid', PARAM_INT);
 $scaleid = required_param('scaleid', PARAM_INT);
-$userrating = required_param('rating'.$itemid, PARAM_INT);
+$userrating = required_param('rating', PARAM_INT);
 $returnurl = optional_param('returnurl', null, PARAM_LOCALURL);//will only be supplied for non-ajax requests
 
 $result = new stdClass;