Refactor create op (scroll-tech#1000)

* create_op: fix memory size (scroll-tech#990)

* create: refactor lifetime

* fmt

* add more tests

* update access list in create

* refactor create

* build

* fix

* try

* ci

bus-mapping/src/circuit_input_builder/input_state_ref.rs

@@ -920,6 +920,7 @@ impl<'a> CircuitInputStateRef<'a> {
         Ok(address)
     }
 
+    /// read reversion info
     pub(crate) fn reversion_info_read(
         &mut self,
         step: &mut ExecStep,
@@ -937,6 +938,24 @@ impl<'a> CircuitInputStateRef<'a> {
         Ok(())
     }
 
+    /// write reversion info
+    pub(crate) fn reversion_info_write(
+        &mut self,
+        step: &mut ExecStep,
+        call: &Call,
+    ) -> Result<(), Error> {
+        for (field, value) in [
+            (
+                CallContextField::RwCounterEndOfReversion,
+                call.rw_counter_end_of_reversion.to_word(),
+            ),
+            (CallContextField::IsPersistent, call.is_persistent.to_word()),
+        ] {
+            self.call_context_write(step, call.call_id, field, value)?;
+        }
+        Ok(())
+    }
+
     /// Check if address is a precompiled or not.
     pub fn is_precompiled(&self, address: &Address) -> bool {
         address.0[0..19] == [0u8; 19] && (1..=9).contains(&address.0[19])

bus-mapping/src/evm/opcodes.rs

@@ -386,6 +386,7 @@ pub fn gen_associated_ops(
     let check_level = if *CHECK_MEM_STRICT { 2 } else { 0 }; // 0: no check, 1: check and log error and fix, 2: check and assert_eq
     if check_level >= 1 {
         let memory_enabled = !geth_steps.iter().all(|s| s.memory.is_empty());
+        assert!(memory_enabled);
         if memory_enabled {
             #[allow(clippy::collapsible_else_if)]
             if state.call_ctx()?.memory != geth_steps[0].memory {