Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the MSRV job #112

Merged
merged 4 commits into from
Jan 5, 2025
Merged

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Jan 1, 2025

parse the MSRV from Cargo.toml to avoid having multiple sources of truth

NB: this will need to be worked if #117 is merged (and vice versa)

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (1a8f6e7) to head (42325e1).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   84.67%   84.00%   -0.67%     
==========================================
  Files          21       20       -1     
  Lines        2212     1901     -311     
==========================================
- Hits         1873     1597     -276     
+ Misses        339      304      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danieleades danieleades marked this pull request as ready for review January 2, 2025 08:05
@davegarred davegarred merged commit e1c2c05 into serverlesstechnology:main Jan 5, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants