-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve dependabot config and commit the lockfile #120
base: main
Are you sure you want to change the base?
improve dependabot config and commit the lockfile #120
Conversation
i expect the tempo and grouping of updates will need some discussion |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 32 32
Lines 3376 3376
=======================================
Hits 2949 2949
Misses 427 427
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
02dcdc1
to
54482c9
Compare
450cb3d
to
e3f4ce2
Compare
What is the argument to commit the lock file here? That feels a little awkward in a library (though it may make sense in the demo). |
There are several arguments, some of which are laid out in this blog post. Specifically for this project, it means that:
The only real downside is a bit more noise from dependabot, but if you like I could add a job for automatically merging dependabot PRs for which all the jobs pass. Take a look at the config and see if it matches the behaviour you would want. For example I could also make minor updates monthly rather than on demand, etc. |
11ada2f
to
ce7f8f8
Compare
@davegarred i've added a job which will automatically merge dependabot PRs that pass CI, though i recommend configuring the repo to not allow merging PRs that are not up-to-date with |
commits the
Cargo.lock
lockfile to version control and updates the dependabot config to limit the 'noise'.