Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move demo into workspace #121

Merged
merged 4 commits into from
Jan 5, 2025
Merged

Conversation

danieleades
Copy link
Contributor

builds on #117 and adds the demo application to the workspace

once again, i have to stress that this is in no way introducing tight coupling between crates that doesn't already exist, it just means that the tight coupling can be managed by making updates to the demo application in lock-step with the core library it demos.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 86.85714% with 207 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (1a8f6e7) to head (935d756).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
persistence/postgres-es/src/error.rs 18.60% 35 Missing ⚠️
persistence/mysql-es/src/error.rs 19.04% 34 Missing ⚠️
persistence/mysql-es/src/cqrs.rs 47.27% 29 Missing ⚠️
persistence/postgres-es/src/cqrs.rs 48.21% 29 Missing ⚠️
persistence/mysql-es/src/event_repository.rs 95.80% 18 Missing ⚠️
persistence/postgres-es/src/event_repository.rs 95.73% 18 Missing ⚠️
persistence/mysql-es/src/testing.rs 70.68% 17 Missing ⚠️
persistence/postgres-es/src/testing.rs 70.68% 17 Missing ⚠️
persistence/mysql-es/src/view_repository.rs 94.79% 5 Missing ⚠️
persistence/postgres-es/src/view_repository.rs 95.09% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   84.67%   86.65%   +1.97%     
==========================================
  Files          21       32      +11     
  Lines        2212     3476    +1264     
==========================================
+ Hits         1873     3012    +1139     
- Misses        339      464     +125     
Flag Coverage Δ
cqrs 84.00% <ø> (?)
mysql 86.91% <86.91%> (?)
postgres 65.15% <86.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danieleades danieleades marked this pull request as ready for review January 5, 2025 08:33
@danieleades danieleades changed the title Demo move demo into workspace Jan 5, 2025
@davegarred davegarred merged commit a3d5f5a into serverlesstechnology:main Jan 5, 2025
15 checks passed
@danieleades danieleades deleted the demo branch January 5, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants