fixes #543 change hibernate-validator and expressly to test scope #544
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to test scope
fjtirado
reviewed
Mar 4, 2025
| <artifactId>hibernate-validator</artifactId> | ||
| <groupId>org.hibernate.validator</groupId> | ||
| <artifactId>hibernate-validator</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Actually these are neeeed at runtime, not just for test, so it should be runtime not test
fjtirado
reviewed
Mar 4, 2025
| <artifactId>expressly</artifactId> | ||
| <groupId>org.glassfish.expressly</groupId> | ||
| <artifactId>expressly</artifactId> | ||
| <scope>test</scope> |
fjtirado
reviewed
Mar 4, 2025
| @@ -34,6 +34,16 @@ | |||
| <groupId>net.thisptr</groupId> | |||
| <artifactId>jackson-jq</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Once you made the other runtime, this does not need to be added and this file should remain unchanged
fjtirado
reviewed
Mar 4, 2025
| @@ -21,6 +21,16 @@ | |||
| <groupId>io.serverlessworkflow</groupId> | |||
| <artifactId>serverlessworkflow-impl-core</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Same, not needed once you set the dependency to runtime, this file should not be modified
fjtirado
requested changes
Mar 4, 2025
fjtirado
reviewed
Mar 4, 2025
| <artifactId>hibernate-validator</artifactId> | ||
| <groupId>org.hibernate.validator</groupId> | ||
| <artifactId>hibernate-validator</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Suggested change
| <scope>test</scope> | |
| <scope>runtime</scope> |
fjtirado
reviewed
Mar 4, 2025
| <artifactId>expressly</artifactId> | ||
| <groupId>org.glassfish.expressly</groupId> | ||
| <artifactId>expressly</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Suggested change
| <scope>test</scope> | |
| <scope>runtime</scope> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):