Merge pull request jpos#614 from tilln/feature/arqc-padding-fix

Fix CVN18 ARQC padding method
servicedesksybyl · Sep 19, 2024 · be62609 · be62609
2 parents 7c882e4 + 5f2fee9
commit be62609
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/jpos/src/main/java/org/jpos/emv/cryptogram/CVN18DataBuilder.java b/jpos/src/main/java/org/jpos/emv/cryptogram/CVN18DataBuilder.java
@@ -50,6 +50,6 @@ public String buildARQCRequest(TLVList data, IssuerApplicationData iad) {
 
     @Override
     public PaddingMethod getPaddingMethod() {
-        return PaddingMethod.ISO9797Method1;
+        return PaddingMethod.ISO9797Method2;
     }
 }
diff --git a/jpos/src/test/java/org/jpos/emv/cryptogram/CVN10DataBuilderTest.java b/jpos/src/test/java/org/jpos/emv/cryptogram/CVN10DataBuilderTest.java
@@ -55,12 +55,9 @@ void testBuildARQCRequest() {
                 "00000000010000000000000008400000000000084018123101ABCDEF101800000203000000",
                 builder.buildARQCRequest(data, iad)
         );
-
         assertEquals(
                 "00000000010000000000000008400000000000084018123101ABCDEF101800000203000000000000",
                 builder.buildARQCRequest_padded(data, iad)
         );
-
-
     }
 }
diff --git a/jpos/src/test/java/org/jpos/emv/cryptogram/CVN18DataBuilderTest.java b/jpos/src/test/java/org/jpos/emv/cryptogram/CVN18DataBuilderTest.java
@@ -55,12 +55,9 @@ void testBuildARQCRequest() {
                 "00000000010000000000000008400000000000084018123101ABCDEF101800000106011203000000",
                 builder.buildARQCRequest(data, iad)
         );
-
         assertEquals(
-                "00000000010000000000000008400000000000084018123101ABCDEF101800000106011203000000",
+                "00000000010000000000000008400000000000084018123101ABCDEF1018000001060112030000008000000000000000",
                 builder.buildARQCRequest_padded(data, iad)
         );
-
-
     }
 }
diff --git a/jpos/src/test/java/org/jpos/emv/cryptogram/CVN22DataBuilderTest.java b/jpos/src/test/java/org/jpos/emv/cryptogram/CVN22DataBuilderTest.java
@@ -55,5 +55,9 @@ void testBuildARQCRequest() {
                 "00000000010000000000000008400000000000084018123101ABCDEF10180000011F22010300000000000000000000000000000000000000000000000000000000",
                 builder.buildARQCRequest(data, iad)
         );
+        assertEquals(
+                "00000000010000000000000008400000000000084018123101ABCDEF10180000011F2201030000000000000000000000000000000000000000000000000000000080000000000000",
+                builder.buildARQCRequest_padded(data, iad)
+        );
     }
 }
diff --git a/jpos/src/test/java/org/jpos/emv/cryptogram/CVNCPADataBuilderTest.java b/jpos/src/test/java/org/jpos/emv/cryptogram/CVNCPADataBuilderTest.java
@@ -34,7 +34,6 @@ void testBuildARQCRequest() {
                 "0000000100000000000010000840000000108008409807040011111111580034560FA500A03800000000000000000000000F010000000000000000000000000000",
                 builder.buildARQCRequest(data, iad)
         );
-
         assertEquals(
                 "0000000100000000000010000840000000108008409807040011111111580034560FA500A03800000000000000000000000F01000000000000000000000000000080000000000000",
                 builder.buildARQCRequest_padded(data, iad)

diff --git a/jpos/src/test/java/org/jpos/emv/cryptogram/CVNMCDataBuilderTest.java b/jpos/src/test/java/org/jpos/emv/cryptogram/CVNMCDataBuilderTest.java
@@ -53,8 +53,10 @@ void buildARPCRequest() {
                 "000000010000000000001000084000000010800840980704001111111158003456608003220000",
                 builder.buildARQCRequest(data, iad)
         );
-
+        assertEquals(
+                "00000001000000000000100008400000001080084098070400111111115800345660800322000080",
+                builder.buildARQCRequest_padded(data, iad)
+        );
     }
 
-
 }