Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per-process options & better per-role options #141

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Support per-process options & better per-role options #141

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5a6cb34
If no :sidekiq_pid is specified, look in the :sidekiq_config
metavida Jan 26, 2016
c997158
Port changes to Cap 3 & remove default sidekiq_pid value
metavida Jan 26, 2016
e7334a6
If pid_file comes from the config file, don't append the idx
metavida Jan 26, 2016
fa3f626
Update README to reflect new sidekiq_pid default given a config
metavida Jan 26, 2016
b67d550
First attempt at per-idx config options
metavida Jan 26, 2016
f168c2f
Add support for per-role Arrays of values
metavida Jan 26, 2016
6f18694
Prepend "sidekiq_" for role-specific configs
metavida Jan 26, 2016
d2abb68
Handle multi-process values for sidekiq_queue
metavida Jan 27, 2016
9bf24af
Add multiple & per-host option examples to the README
metavida Jan 27, 2016
25ee28f
Untested port per-process options to Cap 2
metavida Jan 27, 2016
410edf1
Get # of processes using our internal helper method
metavida Jan 27, 2016
c53ca06
Fix bug when no :sidekiq_queues value is set
metavida Jan 27, 2016
6f1e626
Allow per-process & per-role sidekiq_pid & sidekiq_env
metavida Jan 27, 2016
1d5b4a0
Add undocumented options to README
metavida Jan 27, 2016
49d184a
Make :sidekiq_timeout per-process & per-role
metavida Jan 27, 2016
efbbc63
Port c53ca065...49d184ab changes to Cap 2
metavida Jan 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README to reflect new sidekiq_pid default given a config 
Also update the default value to reflect the change made in #116
  • Loading branch information
@metavida
metavida committed Jan 26, 2016
commit fa3f626b86887d6627e2b238342912753cd89b67
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ Configurable options, shown here with defaults:

```ruby
:sidekiq_default_hooks => true
:sidekiq_pid => File.join(shared_path, 'tmp', 'pids', 'sidekiq.pid')
:sidekiq_pid => File.join(shared_path, 'tmp', 'pids', 'sidekiq-0.pid') # if you specify a pidfile in your sidekiq_config file that value will be used as the default.
:sidekiq_env => fetch(:rack_env, fetch(:rails_env, fetch(:stage)))
:sidekiq_log => File.join(shared_path, 'log', 'sidekiq.log')
:sidekiq_options => nil
:sidekiq_require => nil
:sidekiq_tag => nil
:sidekiq_config => nil # if you have a config/sidekiq.yml, do not forget to set this.
:sidekiq_config => nil # if you have a config/sidekiq.yml, do not forget to set this.
:sidekiq_queue => nil
:sidekiq_timeout => 10
:sidekiq_role => :app
Expand Down