[FAB-15351] Retire fab-zookeeper and fab-kafka

Use publicly available images for Zookeeper and Kafka, rather than the ones we build today Signed-off-by: Brett Logan <[email protected]> Change-Id: I77a147e42ff7d80a8c4b082728fae82b96fbdeae
seuzht · Oct 21, 2019 · 792e98f · 792e98f
1 parent 086a3ba
commit 792e98f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/Makefile b/Makefile
@@ -48,7 +48,10 @@ PREV_VERSION = 2.0.0-alpha
 BASEIMAGE_RELEASE = 0.4.16
 
 # 3rd party image version
+# These versions are also set in the runners in ./integration/runners/
 COUCHDB_VER ?= 2.3
+KAFKA_VER ?= 5.3.1
+ZOOKEEPER_VER ?= 5.3.1
 
 # Disable implicit rules
 .SUFFIXES:
@@ -153,10 +156,8 @@ unit-tests: unit-test
 .PHONY: docker-thirdparty
 docker-thirdparty:
 	docker pull couchdb:${COUCHDB_VER}
-	docker pull $(BASE_DOCKER_NS)/fabric-zookeeper:$(BASE_DOCKER_TAG)
-	docker tag $(BASE_DOCKER_NS)/fabric-zookeeper:$(BASE_DOCKER_TAG) $(DOCKER_NS)/fabric-zookeeper
-	docker pull $(BASE_DOCKER_NS)/fabric-kafka:$(BASE_DOCKER_TAG)
-	docker tag $(BASE_DOCKER_NS)/fabric-kafka:$(BASE_DOCKER_TAG) $(DOCKER_NS)/fabric-kafka
+	docker pull confluentinc/cp-zookeeper:${ZOOKEEPER_VER}
+	docker pull confluentinc/cp-kafka:${KAFKA_VER}
 	docker pull hyperledger/fabric-ccenv:1.4
 
 .PHONY: verify

diff --git a/integration/runner/kafka.go b/integration/runner/kafka.go
@@ -21,7 +21,7 @@ import (
 	"github.com/tedsuo/ifrit"
 )
 
-const KafkaDefaultImage = "hyperledger/fabric-kafka:latest"
+const KafkaDefaultImage = "confluentinc/cp-kafka:5.3.1"
 
 // Kafka manages the execution of an instance of a dockerized CouchDB
 // for tests.

diff --git a/integration/runner/zookeeper.go b/integration/runner/zookeeper.go
@@ -20,7 +20,7 @@ import (
 	"github.com/tedsuo/ifrit"
 )
 
-const ZooKeeperDefaultImage = "hyperledger/fabric-zookeeper:latest"
+const ZooKeeperDefaultImage = "confluentinc/cp-zookeeper:5.3.1"
 
 type ZooKeeper struct {
 	Client         *docker.Client
@@ -104,8 +104,9 @@ func (z *ZooKeeper) Run(sigCh <-chan os.Signal, ready chan<- struct{}) error {
 		Config: &docker.Config{
 			Image: z.Image,
 			Env: []string{
-				fmt.Sprintf("ZOO_MY_ID=%d", z.ZooMyID),
-				fmt.Sprintf("ZOO_SERVERS=%s", z.ZooServers),
+				fmt.Sprintf("ZOOKEEPER_MY_ID=%d", z.ZooMyID),
+				fmt.Sprintf("ZOOKEEPER_SERVERS=%s", z.ZooServers),
+				fmt.Sprintf("ZOOKEEPER_CLIENT_PORT=%s", z.ClientPort.Port()),
 			},
 		},
 	}