Skip to content

Commit

Permalink
kernel: robustify dependencies in kmod-sound-hda-core
Browse files Browse the repository at this point in the history
Dependency tracking for kmod-sound-hda-core is fragile. Enabling some sound
codecs (Realtek, Conexant, Sigmatel) implicitly adds a kmod-ledtrig-audio
dependency, while an enabled kmod-ledtrig-audio can be picked up through
enabling others (e.g. kmod-sound-hda-intel), and the behaviour can change
across kernel versions.

As kmod-ledtrig-audio is under 2KB, make it an unconditional dependency.

Fixes: a374b8f ("kernel: 5.10: update sound modules")
Signed-off-by: Tony Ambardar <[email protected]>
  • Loading branch information
guidosarducci authored and aparcar committed Mar 21, 2021
1 parent 956490a commit 2ba0ab1
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions package/kernel/linux/modules/sound.mk
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,7 @@ $(eval $(call KernelPackage,sound-dummy))
define KernelPackage/sound-hda-core
SUBMENU:=$(SOUND_MENU)
TITLE:=HD Audio Sound Core Support
DEPENDS:= \
+LINUX_5_10&&PACKAGE_kmod-sound-hda-codec-realtek:kmod-ledtrig-audio \
+LINUX_5_10&&PACKAGE_kmod-sound-hda-codec-conexant:kmod-ledtrig-audio \
+LINUX_5_10&&PACKAGE_kmod-sound-hda-codec-idt:kmod-ledtrig-audio
DEPENDS:=+kmod-ledtrig-audio
KCONFIG:= \
CONFIG_SND_HDA_CORE \
CONFIG_SND_HDA_HWDEP=y \
Expand Down

0 comments on commit 2ba0ab1

Please sign in to comment.