Fix handling of user-related course form errors #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query used to include deleted pseudonyms. If a user had an older pseudonym with the same name but a different sis_user_id, the query would return the incorrect sis_user_id, which would prevent the instructor from being enrolled in the new course(s). Fixes INC0107728
|
You've misspelled characters as charaters in commit 676a010. |
Previously, when a nonexistent Computing ID was entered, the form would get stuck at the loading step. Now, the form displays an error and allows the user to make corrections. Test plan: * Load the Start a New Course form * Click "Create a Course for Someone Else" * Enter a nonexistent Computing ID * Verify that you get an error alert about the invalid Computing ID * Click OK and verify that you see the previous screen * Enter a valid Computing ID * Verify that you are asked what type of course to create (as before)
va7map
force-pushed
the
fix-course_form-user_handling
branch
from
676a010 to
8f259e7
Compare
|
@va7map Thanks! 👍 |
|
🌈 |
grahamb
added a commit
that referenced
this pull request
Sep 18, 2015
Fix handling of user-related course form errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes address problems caused by deleted pseudonyms and invalid Computing IDs. Please see individual commit messages for details.