Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course form plugin #24

Merged
merged 5 commits into from
Feb 28, 2013
Merged

Course form plugin #24

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2534536
Added check for undefined value when checking for SFU Computing ID
ronvs Feb 28, 2013
a3d784d
Fix spacing between checkbox and course title
ronvs Feb 28, 2013
1d0533f
Fixed spacing issue on form to match html/css used by Canvas
ronvs Feb 28, 2013
e6a21c6
Improved spacing between checkboxes
ronvs Feb 28, 2013
7b61f90
Disabled cross-list feature if selected courses span different terms
ronvs Feb 28, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improved spacing between checkboxes 
Removed <p> tags around checkboxes
  • Loading branch information
@ronvs
ronvs committed Feb 28, 2013
commit e6a21c60f032cb1943fa3bc763900f31d5c88f2a
4 changes: 2 additions & 2 deletions public/sfu/js/course_request_form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
course_display += "<br><label> (Includes section tutorials: " + section_tutorials + ") </label>";
}
var course_value = course.key;
var checkbox_html = '<p>&nbsp;&nbsp;<label class="checkbox"><input type="checkbox" name="selected_course_'+ num +'" id="selected_course_'+ num +'" value="' + course_value + '">' + course_display + '</label></p>';
var checkbox_html = '<label class="checkbox"><input type="checkbox" name="selected_course_'+ num +'" id="selected_course_'+ num +'" value="' + course_value + '">' + course_display + '</label>';
$("#"+term+"_courses").append(checkbox_html);
num++;
});
Expand Down Expand Up @@ -211,7 +211,7 @@
success: function(data) {
if (data.sis_source_id != "sandbox-" + sfuid + "-1:::course") {
$("#course_list").append("<div id='sandbox'><h4>Other</h4></div>");
var checkbox_html = '<p>&nbsp;&nbsp;<label class="checkbox"><input type="checkbox" name="selected_course_sandbox" id="selected_course_sandbox" value="sandbox" onchange="enable_submit_crosslist();">' + title + '</label></p>';
var checkbox_html = '<label class="checkbox"><input type="checkbox" name="selected_course_sandbox" id="selected_course_sandbox" value="sandbox" onchange="enable_submit_crosslist();">' + title + '</label>';
$("#sandbox").append(checkbox_html);
}
},
Expand Down