Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused @numberOfFrozenCols from Gradebook #260

Merged
merged 1 commit into from
May 3, 2017
Merged

Remove unused @numberOfFrozenCols from Gradebook #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unused @numberOfFrozenCols from Gradebook 
`@numberOfFrozenCols` was removed in an upstream change:

  > instructure/canvas-lms@62db47a

Our SFU MOD to modify `@numberOfFrozenCols` is no longer needed because
the frozen column count is now determined by the length of
`@parentColumns`, which is where we have always added the SIS ID column.

This commit should not result in any functional changes.
  • Loading branch information
@va7map
va7map committed May 1, 2017
commit e1b803d6401a0b09c070040fb963489909a6b908
2 changes: 0 additions & 2 deletions app/coffeescripts/gradebook/Gradebook.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ define [
@showInactiveEnrollments =
@options.settings['show_inactive_enrollments'] == "true"
@totalColumnInFront = UserSettings.contextGet 'total_column_in_front'
@numberOfFrozenCols = if @totalColumnInFront then 3 else 2
++@numberOfFrozenCols # SFU MOD - CANVAS-188 Add extra column for SIS ID
@gradingPeriods = GradingPeriodsApi.deserializePeriods(@options.active_grading_periods)
if @options.grading_period_set
@gradingPeriodSet = GradingPeriodSetsApi.deserializeSet(@options.grading_period_set)
Expand Down