Restore jqueryUI accordion functionality removed by Canvas commit. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va7map
reviewed
Aug 11, 2017
grahamb
reviewed
Aug 11, 2017
public/sfu/js/sfu.js
Outdated
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| */ | |||
|
|
|||
| !function(s,d,url,e,p){ | |||
There was a problem hiding this comment.
Can you add a comment here to explain what this is doing here, for future us?
|
@va7map unpkg.com is trustworthy, I don't have a problem with pulling it from there (it's a CDN for npm modules). Bonus is that https://unpkg.com/widgetize-canvas-lms-user-content redirects to the most recent published version, so we don't need to keep it up to date. |
grahamb
requested changes
Aug 11, 2017
grahamb
approved these changes
Aug 11, 2017
|
Thanks @patchin. Go ahead and upload to prod. |
|
Ok thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround which restores jqueryUI accordion functionality removed by the following commit: instructure@44ed07d
Taken from: 'https://github.com/ryankshaw/widgetize-canvas-lms-user-content'