add QTIMigrationTool #3

grahamb · 2012-11-29T22:21:42Z

No description provided.

add QTIMigrationTool

test plan: - with draft state enabled for the course - index page * ensure the toolbar sticks when scrolling * ensure deleting a page works properly * ensure editing a page works properly - show page * ensure the toolbar sticks when scrolling - edit page (window #1) * open another window to the corresponding show page (window #2) * open another window to the same edit page (window #3) * make a change to the page body in window #1 * save the change - window #2 & #3 should show reload inicators within 30 seconds - window #3 should indicate that someone else's changes will be overwritten by the save * click reload (window #2) - the content should be updated to reflect the changes * click reload (window #3) - the content should be updated to reflect the changes * making changes to the body and saving should still work fixes CNVS-7510 Change-Id: Icf441771589950a0398bf4cbffb4449d1e19eb5b Reviewed-on: https://gerrit.instructure.com/23951 Reviewed-by: Jeremy Stanley <[email protected]> Tested-by: Jenkins <[email protected]> QA-Review: Hannah Bottalla <[email protected]> QA-Review: August Thornton <[email protected]> Product-Review: Matt Goodwin <[email protected]>

fixes CAT-517 Issue: The information stored in ContextModuleProgression#requirements_met is not always completely accurate due to edge cases that result from moving module items between modules. This was leading to cases where the value returned by the API for requirement_count was actually lower than the requirement_completed_count. This fix makes it so that duplicate requirements_met are filtered out. Test plan: 1. As a teacher, make a couple of Modules and add a couple Module Items to each. Set up completion requirements and require sequential progress. 2. As a student, complete a couple of module items. 3. Verify the info returned from the course progress API is as expected. 4. As a teacher, shuffle module items around a bit (e.g. move items from Module 1 into Module 2). 5. As a student, complete the same module items you completed before. 6. Ensure the info returned from the course progress API still reflects actual student progress. Issue #2: A module with no requirements should not cause an API error. Issue #3: A module structured as follows: Module [published] Module Item 1 [unpublished] Module Item 2 [published] Should return a next_requirement_url for Module Item 2, rather than nil. Change-Id: I93ad9e3877ca56806f87c71207e156731510033b Reviewed-on: https://gerrit.instructure.com/40942 Tested-by: Jenkins <[email protected]> Reviewed-by: Jeff Belser <[email protected]> Product-Review: Adam Phillipps <[email protected]> QA-Review: Adam Phillipps <[email protected]>

Fixes CNVS-15692 Test plan: - Create a course with a section - Create 3 students and enroll them in the course under the section you created - Create a teacher and enroll them in the course under that same section - On the course's "People" page, click the teacher's name, then limit them to viewing only students in their same section - Create a group set with two groups - Add student #1 to group #1 and students #2 and #3 to group #2 - As the teacher, open the inbox, create a new message, choose to add all users in group #1 as recipients, and verify that only student #1 shows up - Choose to add all users in group #2 as recipients and verify that only students #2 and #3 show up - As an admin, move student #1 to group #2 and students #2 and #3 to group #1 - As the teacher, open the inbox, create a new message, choose to add all users in group #1 as recipients, and verify that only students #1 and #2 show up - Choose to add all users in group #2 as recipients and verify that only student #1 shows up Change-Id: If8016fef727415cc8f590017f84a07c09c78c0eb Reviewed-on: https://gerrit.instructure.com/57269 Tested-by: Jenkins Reviewed-by: Joel Hough <[email protected]> QA-Review: Adrian Russell <[email protected]> Product-Review: Alex Boyd <[email protected]>

This allows the submission API to consider the crodcodoc_whitelist (needed for Moderated Grading selections) when generating preview_urls. fixes CNVS-33531 test plan: - Create a course with 3 teachers, and a student - Create an assignment that takes a crodococ supported format as a submission and is moderated - As the student, submit homework - As the student, leave crocodoc annotations on the homework - As teacher #1, select moderate, select the student, and add reviewer - As teacher #2, grade the assignment and add crocodoc comments - As teacher #3, grade the assignment and add crocodoc comments - As teacher #1, go into speedgrader, click Add Review and select "Add Moderator Review(Copy 1st)" and leave additional annotations - As teacher #1, post the grades - As either teacher or student hit the API endpoint: /api/v1/courses/<course_id>/assignments/<assignment_id>/submissions?include[]=submission_history - In the json blob, find the preview_url and open it in your browser. Note that the annotations for the student, and teacher #1 and #2 appear Change-Id: I09464a74ec2c2a4167b3225c46c0ac9131109e23 Reviewed-on: https://gerrit.instructure.com/96486 Tested-by: Jenkins Reviewed-by: Neil Gupta <[email protected]> Reviewed-by: Spencer Olson <[email protected]> Reviewed-by: Derek Bender <[email protected]> QA-Review: KC Naegle <[email protected]> Product-Review: Keith T. Garner <[email protected]>

fixes CNVS-33813 Assignments that involve moderated grading would fail to post if reviewers commented on a submission without grading it. Such assignments will now post a nil grade to the corresponding submission when the moderator posts grades. test plan: * Create an assignment with moderated grading * Ensure it has at least three students and two reviewers * In SpeedGrader, for the first student, just leave a comment but no grade * For the second student, give them a score from two different reviewers * For the third student, give them a score from just one reviewer * Attempt to post grades (without selecting a provisional grade for student #2 or #3. * Posting should fail. * Now select a provisional grade for student #2 and attempt posting grades. * Posting should succeed. Try this with concluded and inactive enrollments for student #1 as well. Change-Id: I3ebd9e66f71740dc5a88f88ba8194140ebf472bf Reviewed-on: https://gerrit.instructure.com/99869 Reviewed-by: Keith T. Garner <[email protected]> Tested-by: Jenkins Reviewed-by: Jeremy Neander <[email protected]> QA-Review: KC Naegle <[email protected]> Product-Review: Keith T. Garner <[email protected]>

closes GRADE-45 test plan: * Create a course in a term with at least two grading periods, one current and one closed * Ensure New Gradebook is enabled for this course * Enroll at least two students in this course: A and B. * Create the following assignments in the default assignment group: * Assignment #1 with 10 points in a closed grading period * Assignment #2 with 10 points beyond the last grading period's close date and ensure it's muted * Assignment #3 with 10 points in the current grading period but ensure that it's due for student B in the closed grading period * Assignment #4 with 10 points in the current grading period * Update the settings for the default assignment group to drop 1 lowest score * Go to the gradebook and ensure all grading periods are shown * Click on the cell for B and Assignment #2 and open up the submission tray * Verify the submission tray has a pill indicating it's muted * Verify the submission tray shows a message indicating the submission is not in any grading period * Using the Assignment arrows from the tray, move to the cell for B and Assignment #1 * Verify the submission tray no longer has the muted pill * Verify the submission tray shows a message indicating the submission is in a closed grading period * Unpublish Assignment #1 and navigate back to the cell for B and Assignment #1 * Verify the submission tray now has a pill indicating it's unpublished * Verify the submission tray does not show any warnings about grading periods * Using the Assignment arrows and the Student arrows from the tray, move to the cell for A and Assignment #3 * Verify the submission tray does not show any warnings about grading periods * Using the Student arrows from the tray, move to the cell for B and Assignment #3 * Verify the submission tray shows a message indicating the submission is in a closed grading period * Grade the submissions for B so that she gets her lowest grade in Assignment #3 * Open the submission tray for B and Assignment #3 * Verify the tray has a pill indicating it was dropped * Using Gradebook filters, change to viewing only the current grading period * Open the tray by clicking on the cell for B and Assignment #4 * Using the assignment arrows from the tray, move to the cell for B and Assignment #3 * Verify the submission tray shows a message indicating the submission is in another grading period Change-Id: I861eb317fa304eeac77642e998b381f638a91485 Reviewed-on: https://gerrit.instructure.com/127849 Tested-by: Jenkins Reviewed-by: Spencer Olson <[email protected]> Reviewed-by: Jeremy Neander <[email protected]> QA-Review: KC Naegle <[email protected]> Product-Review: Matt Goodwin <[email protected]>

closes GRADE-345 This also shows a warning to the user indicating the enrollment they're looking at is concluded. test plan: * Create a course in a term with at least two grading periods, one current and one closed * Ensure New Gradebook is enabled for this course * Enroll at least three students in this course: A, B and C. * Create the following assignments in the default assignment group: * Assignment #1 with 10 points in a closed grading period * Assignment #2 with 10 points beyond the last grading period's close date and ensure it's muted * Assignment #3 with 10 points in the current grading period but ensure that it's due for student B in the closed grading period * Assignment #4 with 10 points in the current grading period * Update the settings for the default assignment group to drop 1 lowest score * Go to the gradebook and ensure all grading periods are shown and that you've chosen to view concluded users * Grade C for Assignment #4 and manually mark her late for 1 day using the Grade Detail Tray * Conclude the enrollment for C and go back to the Gradebook * Click on the cell for B and Assignment #2 and open up the submission tray. This submission is not in any grading period. * Verify the late policy radio buttons are visible and enabled * Using the Assignment arrows from the tray, move to the cell for B and Assignment #1. This assignment is published at this time. * Verify the late policy radio buttons are visible and enabled. * Unpublish Assignment #1 and navigate back to the cell for B and Assignment #1. This assignment is now unpublished. * Verify the late policy radio buttons are visible but disabled * Using the Assignment arrows and the Student arrows from the tray, move to the cell for A and Assignment #3 * Verify the late policy radio buttons are visible and enabled * Using the Student arrows from the tray, move to the cell for B and Assignment #3. This submission is in a closed grading period. * Verify the late policy radio buttons are visible but disabled * Using Gradebook filters, change to viewing only the current grading period * Open the tray by clicking on the cell for B and Assignment #4 * Using the assignment arrows from the tray, move to the cell for B and Assignment #3. This submission is in another grading period. * Verify the late policy radio buttons are visible but disabled * Using the Assignment arrows and the Student arrows from the tray, move to the cell for C and Assignment #4. * Verify that the Grade Details Tray shows a warning about the student's enrollment being concluded * Verify that the late policy radio buttons show up but are disabled * Verify that the late policy text input field also shows up but is disabled Change-Id: I6f4e5940c89155dad42710889c6d5298e35743e8 Reviewed-on: https://gerrit.instructure.com/131351 Reviewed-by: Jeremy Neander <[email protected]> Tested-by: Jenkins Reviewed-by: Spencer Olson <[email protected]> QA-Review: Anju Reddy <[email protected]> Product-Review: Matt Goodwin <[email protected]>

In the Grade Export and MGP Grade Export reports, add two columns at the end of each row to represent a student's unposted current and final scores. In the MGP report, add the columns for each grading period alongside the existing current and final scores. closes GRADE-115 Test plan: Gradebook Export: - Set up a course with a section and make sure it is part of an enrollment term. - Add at least one student (the student must have a pseudonym to be included in the output). - Add three assignments to the course: - A published and graded assignment (#1) - A published, graded and *muted* assignment (#2) - A published assignment with no grade (#3) - Run the report (Admin -> Settings -> Report -> Grade Export). For all students graded as specified above, the following should hold: - "current score" should take into account #1 - "final score" should score #1 and treat #2/#3 as zero points - "unposted current score" should take into account #1/#2 - "unposted final score" should take into account all three and treat #3 as zero points MGP Gradebook Export: - Create a course with multiple grading periods and a mix of graded/ungraded and muted/unmuted assignments as described above. - Run the MGP Gradebook Export report; in the output, check that each individual grading period now has columns for unposted current/final scores and that they obey the above rules. - Also make sure that, as with the above report, columns for the unposted scores (over all grading periods) now appear at the end. - Finally, delete one of the grading periods you created and check that the deleted period is *not* included in the report or factored into the total values. Change-Id: Iefc7fcd7036442057af22abc63a870552e159764 Reviewed-on: https://gerrit.instructure.com/137903 Reviewed-by: Shahbaz Javeed <[email protected]> Tested-by: Jenkins Reviewed-by: Spencer Olson <[email protected]> QA-Review: Spencer Olson <[email protected]> Product-Review: Matt Goodwin <[email protected]>

When we switch students in SpeedGrader and the new student has no submission, clear the contents of the submission-holding iframe rather than merely hiding it. This prevents an issue with per-question quiz grading (which is intended to retain selection on the selected question when moving between users) that could occur when selecting a student who had not yet submitted anything, since the contents of the now-hidden iframe were receiving events that assumed they were visible. fixes GRADE-1322 Test plan: * Have a course with a couple students * Create a quiz with a few questions (enough that the quiz would not all fit on the screen in SpeedGrader) * Fill out the quiz for several students * As a teacher, open the quiz in SpeedGrader * From the settings menu, enable the "Grade by question" option (this should reload the page automatically) * When you navigate between students in the following ways, check that the currently-focused question remains focused for the new student. (That is, if you had (say) question #3 selected before switching students, the new student's answer to question #3 should be shown.) * From a student who has taken the quiz to another student who has taken it * From a student who has taken the quiz, to one who has not, then back to one who has taken it Change-Id: I23d14b05441a9ada02b9adb68a4ca95804c7c93a Reviewed-on: https://gerrit.instructure.com/157995 Reviewed-by: Gary Mei <[email protected]> Tested-by: Jenkins Reviewed-by: Spencer Olson <[email protected]> QA-Review: James Butters <[email protected]> Product-Review: Sidharth Oberoi <[email protected]>

Add MathJax Support to Canvas Pages

closes MAT-47 flag=expand_cc_languages Update the list of closedCaptionLanguages to all those supported in Canvas. How did I come up with the list? 1. load a page with an RCE 2. set a breakpoint at the bottom of closedCaptionLanguages and refresh 3. copy the result of `Object.keys(closedCaptionLanguages)`. This are the old locales 4. open a rails console 5. run cnvs_l = [] I18n.available_locales.each {|s| cnvs_s << s.to_s} old_l = <paste result of #3 above> the_missing_locales = cnvs_l - old_l I added the missing locales to closedCaptionLanguages. Then I removed zh_cn and zh_tw because those are not Simplified and Traditional Chinese, but PRC and Taiwan Chinese. I changed Hebrew from iw to he. I left languages in the closedCaptionLanguages.js file that are not in Canvas. I did not use the *-x-k12 locales test plan: - put the user in English (Canada) and turn on the auto show closed caption feature - on a video in the RCE, open the Video Options tray - click on the + subtitle button > expect the full list of locales (like English (UK) and Armenian) - add subtitles for English and English (UK) a valid .srt file looks like: 1 00:00:00,000 --> 00:00:02,000 My first video it will be helpful to edit the string a little for the different languages so you can recognize what language file is being shown. > expect generic english captions - Delete the English subtitle and add any other language but English > expect the subtitles to be in English (UK) - add subtitles for English (Canada) > expect subtitles to be in English (Canada) Change-Id: I8f18d666482a67063a3b8101b7778e32cd440b45 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262794 Tested-by: Service Cloud Jenkins <[email protected]> Reviewed-by: Nate Armstrong <[email protected]> QA-Review: Nate Armstrong <[email protected]> Product-Review: Ed Schiebel <[email protected]>

* Remove Preview from menu item on Received Content page. Co-authored-by: Patrick Chin <[email protected]> Co-authored-by: Andrew Leung <[email protected]>

grahamb added 2 commits November 29, 2012 14:14

change certain delayed jobs to run during the 3am hour instead of 11am

36d3bcf

add QTIMigrationTool

4cc7db5

grahamb added a commit that referenced this pull request Nov 29, 2012

Merge pull request #3 from grahamb/dev

12d6b8c

add QTIMigrationTool

grahamb merged commit 12d6b8c into sfu:deploy Nov 29, 2012

grahamb added a commit that referenced this pull request Nov 8, 2019

Merge pull request #3 from sfu/sfujs-mathjax

4aab601

Add MathJax Support to Canvas Pages

grahamb pushed a commit that referenced this pull request Jun 28, 2021

Remove preview menu item (#3)

e4c6a0b

* Remove Preview from menu item on Received Content page. Co-authored-by: Patrick Chin <[email protected]> Co-authored-by: Andrew Leung <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add QTIMigrationTool #3

add QTIMigrationTool #3

grahamb commented Nov 29, 2012

add QTIMigrationTool #3

add QTIMigrationTool #3

Conversation

grahamb commented Nov 29, 2012