feat(pageAction): show page action when instrumentation is active

Closes angular#199
sg-uap-ui · Dec 22, 2014 · a219e1c · a219e1c
1 parent 68b72bf
commit a219e1c
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/background.js b/background.js
@@ -11,6 +11,9 @@ function bufferOrForward(message, sender) {
 
   if (!data[tabId] || message === 'refresh') {
     resetState(tabId);
+
+    // TODO: this is kind of a hack-y spot to put this
+    showPageAction(tabId);
   }
 
   // TODO: not sure how I feel about special-casing `refresh`
@@ -97,3 +100,12 @@ chrome.tabs.onRemoved.addListener(function (tabId) {
     delete data[tabId];
   }
 });
+
+
+function showPageAction(tabId) {
+  chrome.pageAction.show(tabId);
+  chrome.pageAction.setTitle({
+    tabId: tabId,
+    title: 'Batarang Active'
+  });
+}
diff --git a/img/icon19.png b/img/icon19.png
diff --git a/img/icon38.png b/img/icon38.png
diff --git a/manifest.json b/manifest.json
@@ -8,18 +8,30 @@
     "tabs",
     "<all_urls>"
   ],
+
   "content_scripts": [
     {
       "matches": ["<all_urls>"],
       "js": ["inject.js"],
       "run_at": "document_start"
     }
   ],
+
   "background": {
     "scripts": [
       "background.js"
     ]
   },
+
+  "page_action": {
+    "default_icon": {
+      "19": "img/icon19.png",
+      "38": "img/icon38.png"
+    },
+
+    "default_title": "AngularJS Super-Powered"
+  },
+
   "web_accessible_resources": [
     "dist/hint.js"
   ],