ipapython/admintool.py: use SERVER_NOT_CONFIGURED

Commit 9182917 introduced SUCCESS, SERVER_INSTALL_ERROR and SERVER_NOT_CONFIGURED to deal with cases when server is not configured. Actually use SERVER_NOT_CONFIGURED in log_failure instead of 2. Related-to: https://pagure.io/freeipa/issue/6843 Signed-off-by: François Cami <[email protected]> Reviewed-By: Alexander Bokovoy <[email protected]> Reviewed-By: Rob Crittenden <[email protected]>
sgoveas · Jul 30, 2019 · 402246a · 402246a
1 parent 11e4033
commit 402246a
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/ipapython/admintool.py b/ipapython/admintool.py
@@ -317,9 +317,7 @@ def log_failure(self, error_message, return_value, exception, backtrace):
             # ipa-server-install.
             return
         message = "The %s command failed." % self.command_name
-        if self.log_file_initialized and return_value != 2:
-            # magic value because this is common between server and client
-            # but imports are not straigthforward
+        if self.log_file_initialized and return_value != SERVER_NOT_CONFIGURED:
             message += " See %s for more information" % self.log_file_name
         logger.error('%s', message)