Skip to content

Commit

Permalink
configure: allow to run clang with ASAN
Browse files Browse the repository at this point in the history
Prefer adding LSAN_OPTIONS="suppressions=$PWD/tests/sanitizer_suppressions/lsan" when CC=clang instead.

Changelog-Added: build: clang build now supports --enable-address-sanitizer .
Signed-off-by: Antoine Poinsot <[email protected]>
  • Loading branch information
darosior authored and rustyrussell committed Sep 24, 2020
1 parent 5a87e88 commit 3382daf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 0 additions & 4 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,6 @@ $CC ${CWARNFLAGS-$BASE_WARNFLAGS} $CDEBUGFLAGS $COPTFLAGS -o $CONFIGURATOR $CONF
echo "done"

if [ "$ASAN" = "1" ]; then
if [ "$CC" = "clang" ]; then
echo "Address sanitizer (ASAN) is currently only supported with gcc"
exit 1
fi
if [ "$VALGRIND" = "1" ]; then
echo "Address sanitizer (ASAN) and valgrind cannot be enabled at the same time"
exit 1
Expand Down
3 changes: 3 additions & 0 deletions contrib/sanitizer_suppressions/asan
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# process_check_funding_broadcast is racy as it operates on a data that may be
# freed under its feet
interceptor_via_fun:process_check_funding_broadcast
3 changes: 3 additions & 0 deletions contrib/sanitizer_suppressions/lsan
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Clang would detect false positive here, due to padding. See https://github.com/ElementsProject/lightning/pull/2285
leak:ccan/ccan/autodata/autodata.c
leak:ccan/ccan/htable/htable.c

0 comments on commit 3382daf

Please sign in to comment.