Remove several more #nullable disables (dotnet#57933)

shadow-cs · Aug 23, 2021 · 896eb15 · 896eb15
1 parent 3863140
commit 896eb15
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/libraries/Common/src/System/CSharpHelpers.cs b/src/libraries/Common/src/System/CSharpHelpers.cs
@@ -1,7 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable
 using System.Collections.Generic;
 using System.Globalization;
 
@@ -117,7 +116,7 @@ public static string CreateEscapedIdentifier(string name)
         ///       independent identifier.
         ///    </para>
         /// </devdoc>
-        public static bool IsValidLanguageIndependentIdentifier(string value)
+        public static bool IsValidLanguageIndependentIdentifier(string? value)
         {
             return IsValidTypeNameOrIdentifier(value, false);
         }
@@ -139,7 +138,7 @@ internal static bool IsPrefixTwoUnderscore(string value)
             }
         }
 
-        internal static bool IsValidTypeNameOrIdentifier(string value, bool isTypeName)
+        internal static bool IsValidTypeNameOrIdentifier(string? value, bool isTypeName)
         {
             bool nextMustBeStartChar = true;
 

diff --git a/src/libraries/Common/src/System/HexConverter.cs b/src/libraries/Common/src/System/HexConverter.cs
@@ -1,7 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-#nullable disable
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
 #if SYSTEM_PRIVATE_CORELIB

diff --git a/src/libraries/System.CodeDom/src/System.CodeDom.csproj b/src/libraries/System.CodeDom/src/System.CodeDom.csproj
@@ -3,6 +3,7 @@
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <DefineConstants>$(DefineConstants);CODEDOM</DefineConstants>
     <TargetFrameworks>$(NetCoreAppCurrent);netstandard2.0;net461</TargetFrameworks>
+    <Nullable>annotations</Nullable>
     <SetIsTrimmable>false</SetIsTrimmable>
     <IsPackable>true</IsPackable>
     <PackageDescription>Provides types that can be used to model the structure of a source code document and to output source code for that model in a supported language.