Remove unnecessary char[] allocation from Uri.GetRelativeSerializatio…

…nString (dotnet#54799)
shadow-cs · Jun 28, 2021 · 985eb81 · 985eb81
1 parent 6fdb82a
commit 985eb81
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/libraries/System.Private.Uri/src/System/UriExt.cs b/src/libraries/System.Private.Uri/src/System/UriExt.cs
@@ -744,11 +744,9 @@ private unsafe string GetRelativeSerializationString(UriFormat format)
                 if (_string.Length == 0)
                     return string.Empty;
 
-                char[] dest = new char[_string.Length];
-                int position = 0;
-                dest = UriHelper.UnescapeString(_string, 0, _string.Length, dest, ref position, c_DummyChar,
-                    c_DummyChar, c_DummyChar, UnescapeMode.EscapeUnescape, null, false);
-                return new string(dest, 0, position);
+                var vsb = new ValueStringBuilder(stackalloc char[StackallocThreshold]);
+                UriHelper.UnescapeString(_string, ref vsb, c_DummyChar, c_DummyChar, c_DummyChar, UnescapeMode.EscapeUnescape, null, false);
+                return vsb.ToString();
             }
             else
             {