Skip to content

Commit

Permalink
Fix bad Docker login instructions (dotnet#410)
Browse files Browse the repository at this point in the history
  • Loading branch information
richlander authored Mar 3, 2018
1 parent 584632b commit ccccaf7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion samples/aspnetapp/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ASP.NET Core Docker Sample

This [sample](Dockerfile) demonstrates how to use ASP.NET Core and Docker together. The sample works with both Linux and Windows containers and can also be used without Docker.
This [sample](Dockerfile) demonstrates how to use ASP.NET Core and Docker together. The sample works with both Linux and Windows containers and can also be used without Docker. There are also instructions that demonstrate how to push the sample to [Azure Container Registry](../dotnetapp/push-image-to-acr.md) and test it with [Azure Container Instance](deploy-container-to-aci.md).

The sample builds the application in a container based on the larger [.NET Core SDK Docker image](https://hub.docker.com/r/microsoft/dotnet/). It builds and tests the application and then copies the final build result into a Docker image based on the smaller [ASP.NET Core Docker Runtime image](https://hub.docker.com/r/microsoft/aspnetcore/). It uses Docker [multi-stage build](https://github.com/dotnet/announcements/issues/18) and [multi-arch tags](https://github.com/dotnet/announcements/issues/14).

Expand Down
2 changes: 1 addition & 1 deletion samples/aspnetapp/deploy-container-to-aci.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ az acr credential show -n richlander
Use the following instructions to login to ACR.

```console
az acr credential show -n richlander | docker login richlander.azurecr.io -u richlander --password-stdin
az acr credential show -n richlander --query passwords[0].value --output tsv | docker login richlander.azurecr.io -u richlander --password-stdin
```

## Push Image for Azure Container Registry (ACR)
Expand Down

0 comments on commit ccccaf7

Please sign in to comment.