Skip to content

Commit

Permalink
chore(repo): disable detox on nightly (nrwl#9092)
Browse files Browse the repository at this point in the history
  • Loading branch information
meeroslav authored Feb 23, 2022
1 parent 4643da2 commit ba74e9c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/e2e-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,15 @@ jobs:
- e2e-web
- e2e-storybook
- e2e-workspace-integrations,e2e-workspace-core,e2e-workspace-create
- e2e-react-native,e2e-detox
- e2e-react-native
# - e2e-detox
- e2e-add-nx-to-monorepo
exclude:
# exclude react-native and detox from ubuntu
- os: ubuntu-latest
packages: e2e-react-native,e2e-detox
packages: e2e-react-native
# - os: ubuntu-latest
# packages: e2e-detox
# run just npm on macos
- os: macos-latest
package_manager: yarn
Expand Down
13 changes: 5 additions & 8 deletions e2e/detox/src/detox.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,16 @@ import {
} from '@nrwl/e2e/utils';

describe('Detox', () => {
beforeEach(() => newProject());
const appName = uniq('myapp');

it('should create files and run lint command', async () => {
const appName = uniq('myapp');
beforeAll(() => {
newProject();
runCLI(
`generate @nrwl/react-native:app ${appName} --e2eTestRunner=detox --linter=eslint`
);
});

it('should create files and run lint command', async () => {
checkFilesExist(`apps/${appName}-e2e/.detoxrc.json`);
checkFilesExist(`apps/${appName}-e2e/tsconfig.json`);
checkFilesExist(`apps/${appName}-e2e/tsconfig.e2e.json`);
Expand All @@ -30,11 +32,6 @@ describe('Detox', () => {
describe('React Native Detox MACOS-Tests', () => {
if (isOSX()) {
it('should build and test ios MACOS-Tests', async () => {
const appName = uniq('myapp');
runCLI(
`generate @nrwl/react-native:app ${appName} --e2eTestRunner=detox --linter=eslint`
);

expect(runCLI(`build-ios ${appName}-e2e --prod`)).toContain(
'Successfully ran target build-ios'
);
Expand Down

0 comments on commit ba74e9c

Please sign in to comment.