fix: register service names

shanbay · Aug 21, 2023 · bf31059 · bf31059
1 parent 0c08e7d
commit bf31059
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,13 +1,15 @@
 # CHANGELOG
 
-## [Unreleased] - 2022-10-25
+## [Unreleased] - 2023-08-21
+### Added
+- Support grpc reflection
 
+## [3.1.0] - 2022-11-10
 ### Changed
 - Upgrade depebdebcies to support python 3.10+
 - Changed CI from Travis CI to Github Actions
 
 ## [3.0.0] - 2022-06-24
-
 ### Added
 - Added multiprocessing worker class
 ### Changed

diff --git a/sea/server/multiprocessing.py b/sea/server/multiprocessing.py
@@ -9,6 +9,7 @@
 from typing import List
 
 import grpc
+from grpc_reflection.v1alpha import reflection
 
 from sea import signals
 
@@ -45,9 +46,9 @@ def _run_server(self, bind_address):
             ],
         )
         self.server = server  # set server in slave process
-        if self.app.config.get("GRPC_REFLECTION", True):
-            from grpc_reflection.v1alpha import reflection
-            reflection.enable_server_reflection((reflection.SERVICE_NAME,), server)
+        # register reflection service
+        if self.app.config.get("GRPC_REFLECTION_SERVICES"):
+            reflection.enable_server_reflection((reflection.SERVICE_NAME, *self.app.config["GRPC_REFLECTION_SERVICES"]), self.server)
 
         for _, (add_func, servicer) in self.app.servicers.items():
             add_func(servicer(), server)

diff --git a/sea/server/threading.py b/sea/server/threading.py
@@ -3,6 +3,7 @@
 from concurrent import futures
 
 import grpc
+from grpc_reflection.v1alpha import reflection
 
 from sea import signals
 
@@ -28,9 +29,9 @@ def run(self):
             from prometheus_client import start_http_server
 
             start_http_server(self.app.config["PROMETHEUS_PORT"])
-        if self.app.config.get("GRPC_REFLECTION", True):
-            from grpc_reflection.v1alpha import reflection
-            reflection.enable_server_reflection((reflection.SERVICE_NAME,), self.server)
+        # register reflection service
+        if self.app.config.get("GRPC_REFLECTION_SERVICES"):
+            reflection.enable_server_reflection((reflection.SERVICE_NAME, *self.app.config["GRPC_REFLECTION_SERVICES"]), self.server)
         # run grpc server
         for name, (add_func, servicer) in self.app.servicers.items():
             add_func(servicer(), self.server)

diff --git a/tests/wd/configs/default/__init__.py b/tests/wd/configs/default/__init__.py
@@ -14,4 +14,5 @@
 
 TIMEZONE = "Asia/Shanghai"
 GRPC_GRACE = 0
+GRPC_REFLECTION_SERVICES = ["helloworld.Greeter"]
 PROMETHEUS_SCRAPE = True