Skip to content

Commit

Permalink
callback: use expired status when playbooks are interrupted
Browse files Browse the repository at this point in the history
The semantic is important: we don't know whether anything has
actually failed but we know the playbook was interrupted.

If anything had failed without 'ignore_errors' or a rescue block, it
would have brought an end to the playbook.

We don't yet have an "interrupted" status for playbooks.

There could be one but for now let's use 'expired' which was created
to actually expire interrupted playbooks that will probably never
finish.
  • Loading branch information
dmsimard committed Aug 25, 2024
1 parent a98b4c9 commit 02420d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ara/plugins/callback/ara_default.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ def set_handler(self, sig):

def handler(sig, frame):
ended = datetime.datetime.now(datetime.timezone.utc).isoformat()
status = "failed"
status = "expired"
self.client.patch(
"/api/v1/playbooks/%s" % self.playbook["id"],
status=status,
Expand Down

0 comments on commit 02420d7

Please sign in to comment.